[GitHub] [maven] elharo commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on PR #1061:
URL: https://github.com/apache/maven/pull/1061#issuecomment-1512925510

   > Should that imply that the properties become `project.rootDirectory`, `session.rootDirectory` and `session.topDirectory` ?
   > I think people are used to `basedir` so I wanted to align with it and make things coherent. If so, I'd rename that one to `project.baseDirectory` too.
   
   I do not think consistency is the most important virtue here. If these are new properties in 4.0, then by all means name the properties rootDirectory, topDirectory, etc. or perhaps some case variant of that like root_directory. I think basedir already exists so I wouldn't rename it. 
   
   My general train of thought is to make the API and properties as clean and readable as possible, even if that introduces some inconsistencies with older API that does not follow best practices.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org