[jira] [Commented] (ZOOKEEPER-1737) zk scripts no longer work when symlinked

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13729947#comment-13729947 ] 

Hadoop QA commented on ZOOKEEPER-1737:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12596200/zookeeper-3.4.5-ZK1731-SC01.patch
  against trunk revision 1503101.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1528//console

This message is automatically generated.
                
> zk scripts no longer work when symlinked
> ----------------------------------------
>
>                 Key: ZOOKEEPER-1737
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1737
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.4.5
>         Environment: RHEL6.4
>            Reporter: Chris Seawood
>         Attachments: zookeeper-3.4.5-ZK1731-SC01.patch
>
>
> At some point since 3.3, the shell scripts were updated to move away from using readlink to using BASH_SOURCE.  The problem is that BASH_SOURCE doesn't resolve symlinks so when /usr/bin/zookeeper-cli is symlinked to /usr/lib/zookeeper/bin/zkCli.sh it fails every single time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira