You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/05 09:13:59 UTC

[GitHub] [shardingsphere] gxxiong opened a new pull request, #22667: add integration test case for encrypt like feature and fix add like columnName by insert

gxxiong opened a new pull request, #22667:
URL: https://github.com/apache/shardingsphere/pull/22667

   Ref #20435.
   
   Changes proposed in this pull request:
     -add integration test case for encrypt like feature
     -fix add like columnName by insert
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [X] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [X] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu merged pull request #22667: add integration test case for encrypt like feature and fix add like columnName by insert

Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22667:
URL: https://github.com/apache/shardingsphere/pull/22667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #22667: add integration test case for encrypt like feature and fix add like columnName by insert

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22667:
URL: https://github.com/apache/shardingsphere/pull/22667#issuecomment-1337039306

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22667?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22667](https://codecov.io/gh/apache/shardingsphere/pull/22667?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fd708c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/61e7a121a77843451d8ca3b3a2df42ead5d42836?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (61e7a12) will **decrease** coverage by `0.00%`.
   > The diff coverage is `52.63%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #22667      +/-   ##
   ============================================
   - Coverage     49.37%   49.37%   -0.01%     
     Complexity     2440     2440              
   ============================================
     Files          4108     4108              
     Lines         57411    57437      +26     
     Branches       9832     9841       +9     
   ============================================
   + Hits          28349    28358       +9     
   - Misses        26619    26633      +14     
   - Partials       2443     2446       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...shardingsphere/mode/metadata/MetaDataContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/22667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL01ldGFEYXRhQ29udGV4dHMuamF2YQ==) | `53.12% <26.31%> (-35.12%)` | :arrow_down: |
   | [...cryptForUseDefaultInsertColumnsTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/22667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL0VuY3J5cHRGb3JVc2VEZWZhdWx0SW5zZXJ0Q29sdW1uc1Rva2VuR2VuZXJhdG9yLmphdmE=) | `68.62% <72.72%> (-0.43%)` | :arrow_down: |
   | [...n/generator/EncryptInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/22667/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL0VuY3J5cHRJbnNlcnRWYWx1ZXNUb2tlbkdlbmVyYXRvci5qYXZh) | `81.52% <87.50%> (-0.71%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org