You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/25 04:19:06 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #43092: [SPARK-45305][TESTS] Remove JDK 8 workaround added TreeNodeSuite
HyukjinKwon opened a new pull request, #43092:
URL: https://github.com/apache/spark/pull/43092
### What changes were proposed in this pull request?
In theory, we don't need https://github.com/apache/spark/pull/29875 anymore because we dropped JDK 8 (according to the PR description) but Utils.getSimpleClass handles malformed class names in any event, so should be safe to keep them.
### Why are the changes needed?
To remove test that does not run. We dropped JDK 11/8 at SPARK-44112
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
CI in this PR should test them out.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #43092: [SPARK-45305][SQL][TESTS] Remove JDK 8 workaround added TreeNodeSuite
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43092: [SPARK-45305][SQL][TESTS] Remove JDK 8 workaround added TreeNodeSuite
URL: https://github.com/apache/spark/pull/43092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #43092: [SPARK-45305][TESTS] Remove JDK 8 workaround added TreeNodeSuite
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43092:
URL: https://github.com/apache/spark/pull/43092#discussion_r1335517628
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala:
##########
@@ -871,28 +871,6 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
}
}
- test("SPARK-32999: TreeNode.nodeName should not throw malformed class name error") {
- val testTriggersExpectedError = try {
- classOf[MalformedClassObject.MalformedNameExpression].getSimpleName
Review Comment:
you're awesome 👍
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala:
##########
@@ -871,28 +871,6 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
}
}
- test("SPARK-32999: TreeNode.nodeName should not throw malformed class name error") {
- val testTriggersExpectedError = try {
- classOf[MalformedClassObject.MalformedNameExpression].getSimpleName
Review Comment:
you're awesome 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #43092: [SPARK-45305][TESTS] Remove JDK 8 workaround added TreeNodeSuite
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43092:
URL: https://github.com/apache/spark/pull/43092#issuecomment-1732881962
cc @rednaxelafx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43092: [SPARK-45305][SQL][TESTS] Remove JDK 8 workaround added TreeNodeSuite
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43092:
URL: https://github.com/apache/spark/pull/43092#issuecomment-1734149607
I verified manually this removal. This suite works fine without any compilation issue.
```
$ build/sbt "catalyst/testOnly *.TreeNodeSuite"
...
[info] Run completed in 1 second, 730 milliseconds.
[info] Total number of tests run: 34
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 34, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 10 s, completed Sep 25, 2023, 10:07:21 AM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #43092: [SPARK-45305][SQL][TESTS] Remove JDK 8 workaround added TreeNodeSuite
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43092:
URL: https://github.com/apache/spark/pull/43092#issuecomment-1734150709
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a diff in pull request #43092: [SPARK-45305][TESTS] Remove JDK 8 workaround added TreeNodeSuite
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #43092:
URL: https://github.com/apache/spark/pull/43092#discussion_r1335451453
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala:
##########
@@ -871,28 +871,6 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
}
}
- test("SPARK-32999: TreeNode.nodeName should not throw malformed class name error") {
- val testTriggersExpectedError = try {
- classOf[MalformedClassObject.MalformedNameExpression].getSimpleName
Review Comment:
Can MalformedClassObject be removed safely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org