You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by sferot <gi...@git.apache.org> on 2018/10/31 14:36:37 UTC

[GitHub] brooklyn-ui pull request #95: Add callback for customising yaml loading

GitHub user sferot opened a pull request:

    https://github.com/apache/brooklyn-ui/pull/95

    Add callback for customising yaml loading

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/usharesoft/brooklyn-ui configure-yaml-load

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-ui/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit c4367b2d51505947e9e3d4f6cbb777678f28dce5
Author: Sylvain Ferot <sy...@...>
Date:   2018-10-24T10:04:29Z

    Allow to configure the blueprint loading methods

----


---

[GitHub] brooklyn-ui issue #95: Add callback for customising yaml loading

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/95
  
    good refactor @sferot .  i note you have an ICLA so this is good to go.
    
    heads up, @tbouron has been spiking angularjs decorators which should provide an easier pattern to override/customize.  if you are wanting to override this you could try that and let us know how it goes!
    
    merging


---

[GitHub] brooklyn-ui issue #95: Add callback for customising yaml loading

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/95
  
    @sferot fix pushed, but pls check it's what you intended
    
    https://github.com/apache/brooklyn-ui/commit/65d37408778365d0d987a46b119deea12f0c70d7



---

[GitHub] brooklyn-ui issue #95: Add callback for customising yaml loading

Posted by ahgittin <gi...@git.apache.org>.

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/95
  
    actually this is giving errors when i run it:
    
    ```
    TypeError: this.$q.defer is not a function
        at BlueprintLoaderApiProvider.loadBlueprint (blueprint-loader-api.provider.js:51)
    ```
    
    will try to fix but if i can't i'll have to revert


---

[GitHub] brooklyn-ui issue #95: Add callback for customising yaml loading

Posted by ludop-usharesoft <gi...@git.apache.org>.

Github user ludop-usharesoft commented on the issue:

    https://github.com/apache/brooklyn-ui/pull/95
  
    Thanks @ahgittin for the merge and the fix
    @sferot is in holidays since last wednesday, he will come back on the 12th.
    If I have the time week I may try to look at it (but not sure).


---

[GitHub] brooklyn-ui pull request #95: Add callback for customising yaml loading

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-ui/pull/95


---