You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/02/22 18:11:53 UTC

Review Request 56942: Test and fix new modals styles on Ambari

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56942/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20118
    https://issues.apache.org/jira/browse/AMBARI-20118


Repository: ambari


Description
-------

Apply updated modal styles to ambari-web and fix inconsistences.


Diffs
-----

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js cb02665 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 81c80e1 
  ambari-web/app/controllers/wizard/step9_controller.js f63bd79 
  ambari-web/app/routes/main.js 14435e8 
  ambari-web/app/styles/enhanced_service_dashboard.less dfbe042 
  ambari-web/app/styles/modal_popups.less a6a0196 
  ambari-web/app/styles/stack_versions.less 0e1d2d0 
  ambari-web/app/styles/theme/bootstrap-ambari.css 2c84f88 
  ambari-web/app/templates/common/assign_master_components.hbs d5eaf75 
  ambari-web/app/templates/common/configs/propertyDependence_footer.hbs ee03ad4 
  ambari-web/app/templates/common/modal_popup.hbs 59e9c0b 
  ambari-web/app/templates/common/progress.hbs 8485698 
  ambari-web/app/templates/main/service/info/save_popup_footer.hbs 4907b3a 
  ambari-web/app/templates/wizard/step3/step3_host_warning_popup_footer.hbs d906b75 
  ambari-web/app/views/common/assign_master_components_view.js 73654c7 
  ambari-web/app/views/common/configs/service_configs_by_category_view.js 25f7dfb 
  ambari-web/app/views/main/admin/kerberos/disable_view.js 64657e8 
  ambari-web/app/views/wizard/step7/assign_master_view.js b795647 

Diff: https://reviews.apache.org/r/56942/diff/


Testing
-------

20373 passing (19s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 56942: Test and fix new modals styles on Ambari

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56942/#review166386
-----------------------------------------------------------


Ship it!




Ship It!

- Aleksandr Kovalenko


On \u0424\u0435\u0432. 22, 2017, 6:11 \u043f.\u043f., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56942/
> -----------------------------------------------------------
> 
> (Updated \u0424\u0435\u0432. 22, 2017, 6:11 \u043f.\u043f.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20118
>     https://issues.apache.org/jira/browse/AMBARI-20118
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Apply updated modal styles to ambari-web and fix inconsistences.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js cb02665 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 81c80e1 
>   ambari-web/app/controllers/wizard/step9_controller.js f63bd79 
>   ambari-web/app/routes/main.js 14435e8 
>   ambari-web/app/styles/enhanced_service_dashboard.less dfbe042 
>   ambari-web/app/styles/modal_popups.less a6a0196 
>   ambari-web/app/styles/stack_versions.less 0e1d2d0 
>   ambari-web/app/styles/theme/bootstrap-ambari.css 2c84f88 
>   ambari-web/app/templates/common/assign_master_components.hbs d5eaf75 
>   ambari-web/app/templates/common/configs/propertyDependence_footer.hbs ee03ad4 
>   ambari-web/app/templates/common/modal_popup.hbs 59e9c0b 
>   ambari-web/app/templates/common/progress.hbs 8485698 
>   ambari-web/app/templates/main/service/info/save_popup_footer.hbs 4907b3a 
>   ambari-web/app/templates/wizard/step3/step3_host_warning_popup_footer.hbs d906b75 
>   ambari-web/app/views/common/assign_master_components_view.js 73654c7 
>   ambari-web/app/views/common/configs/service_configs_by_category_view.js 25f7dfb 
>   ambari-web/app/views/main/admin/kerberos/disable_view.js 64657e8 
>   ambari-web/app/views/wizard/step7/assign_master_view.js b795647 
> 
> Diff: https://reviews.apache.org/r/56942/diff/
> 
> 
> Testing
> -------
> 
> 20373 passing (19s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>