You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/28 05:58:32 UTC

[GitHub] [netbeans] mbien commented on a diff in pull request #1877: [NETBEANS-3604]Supports for Records (JEP 359) in JDK-14"

mbien commented on code in PR #1877:
URL: https://github.com/apache/netbeans/pull/1877#discussion_r908063525


##########
java/java.navigation/src/org/netbeans/modules/java/navigation/ElementScanningTask.java:
##########
@@ -358,7 +360,7 @@ private Description element2description(final Element e, final Element parent,
         } else if( e instanceof ExecutableElement ) {
             d.htmlHeader = createHtmlHeader(info,  (ExecutableElement)e, info.getElements().isDeprecated(e),d.isInherited, fqn, overridenFrom);
         } else if( e instanceof VariableElement ) {
-            if( !(e.getKind() == ElementKind.FIELD || e.getKind() == ElementKind.ENUM_CONSTANT) )
+            if( !(e.getKind() == ElementKind.FIELD || e.getKind() == ElementKind.ENUM_CONSTANT || e.getKind().name().equals("STATE_COMPONENT")) )

Review Comment:
   @singh-akhilesh should this be `RECORD_COMPONENT`? ElementKind does not have a `STATE_COMPONENT`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists