[GitHub] tzulitai opened a new pull request #7434: [FLINK-11287] [rocksdb] RocksDBListState should be using registered serializer in state meta infos

[GitBox <gi...@apache.org>]

tzulitai opened a new pull request #7434: [FLINK-11287] [rocksdb] RocksDBListState should be using registered serializer in state meta infos
URL: https://github.com/apache/flink/pull/7434
 
 
   ## What is the purpose of the change
   
   `RocksDBListState` was using the serializer provided by the state descriptor, which is incorrect because that serializer have not been checked for compatibility or reconfigured if required.
   
   Instead, it should be using the actual resulting registered serializer in the backend's state meta infos, which is guaranteed to have been checked for compatibility.
   
   ## Brief change log
   
   - 9317611: the main change as described in description
   - 6b7401c: Validates the fix by activating a previously ignored test in `StateBackendMigrationTestBase`. That test wasn't passing due to FLINK-11073 and FLINK-11287 (which this PR fixes).
   
   ## Verifying this change
   
   The previously ignored test `StateBackendMigrationTestBase.testKeyedListStateSerializerReconfiguration` should now pass, as FLINK-11287 is partially the reason of why it wasn't passing before.
   
   That test verifies that `RocksDBListState` is indeed using the correct, compatibility-checked / reconfigured serializer.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services