You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/12/30 08:30:02 UTC

Review Request 29477: CLOUDSTACK-8135: Fixed cleanup issue in test_escalations_instances.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29477/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-8135
    https://issues.apache.org/jira/browse/CLOUDSTACK-8135


Repository: cloudstack-git


Description
-------

The test case failed in cleanup operation because the VM gets cleaned up as a part of account cleanup. Hence no need to add the VM in to cleanup list explicitly.


Diffs
-----

  test/integration/component/test_escalations_instances.py 1e5ec53 

Diff: https://reviews.apache.org/r/29477/diff/


Testing
-------

@Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 167.918s

OK


Thanks,

Ashutosh Kelkar


Re: Review Request 29477: CLOUDSTACK-8135: Fixed cleanup issue in test_escalations_instances.py

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.

> On Jan. 5, 2015, 1:21 p.m., SrikanteswaraRao Talluri wrote:
> > 1ee41888353d87f4972e6ccb492817133805a88e master
> > 4e7f0d277b36be91ef041fc5ae59002679abe2e1 4.5

correcting the hash for 4.5 613aa8ea28b7670b13792a638fc493b6fe8ebb21


- SrikanteswaraRao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29477/#review66634
-----------------------------------------------------------


On Dec. 30, 2014, 7:30 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29477/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 7:30 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8135
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8135
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case failed in cleanup operation because the VM gets cleaned up as a part of account cleanup. Hence no need to add the VM in to cleanup list explicitly.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_instances.py 1e5ec53 
> 
> Diff: https://reviews.apache.org/r/29477/diff/
> 
> 
> Testing
> -------
> 
> @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 167.918s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 29477: CLOUDSTACK-8135: Fixed cleanup issue in test_escalations_instances.py

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29477/#review66634
-----------------------------------------------------------

Ship it!


1ee41888353d87f4972e6ccb492817133805a88e master
4e7f0d277b36be91ef041fc5ae59002679abe2e1 4.5

- SrikanteswaraRao Talluri


On Dec. 30, 2014, 7:30 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29477/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 7:30 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8135
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8135
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case failed in cleanup operation because the VM gets cleaned up as a part of account cleanup. Hence no need to add the VM in to cleanup list explicitly.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_instances.py 1e5ec53 
> 
> Diff: https://reviews.apache.org/r/29477/diff/
> 
> 
> Testing
> -------
> 
> @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 167.918s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>