You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/02/10 19:08:36 UTC
[GitHub] [trafficserver] ezelkow1 opened a new pull request #8664: fix hosting.config reload
ezelkow1 opened a new pull request #8664:
URL: https://github.com/apache/trafficserver/pull/8664
When hosting.config reloads, currently the file is properly loaded and placed in a new hosting table. However when ats goes to place it in use in the current cache structure it's using an ink_atomic_swap(new_table, old_table). This function does not actually swap, it only does a set, so it effectively overwrites the new table with the old table, and then continues, never updating. This is why reloading with a new hosting.config never sees an update in use.
This PR changes that to get rid of the ink_atomic use and just use a std_atomic for the table, replaces the host table ptr, and deletes the old one
closes #7220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8664: fix hosting.config reload
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8664:
URL: https://github.com/apache/trafficserver/pull/8664#issuecomment-1035661150
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8664: fix hosting.config reload
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8664:
URL: https://github.com/apache/trafficserver/pull/8664#issuecomment-1045219710
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8664: fix hosting.config reload
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8664:
URL: https://github.com/apache/trafficserver/pull/8664#issuecomment-1067406169
suggestion from @SolidWallOfCode to take a look at the ipallow logic and see if we can do similar here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org