[GitHub] [incubator-superset] rusackas commented on pull request #11160: refactor: Replace react-bootstrap Tabs with Antd Tabs in DashboardBuilder

[GitBox <gi...@apache.org>]

rusackas commented on pull request #11160:
URL: https://github.com/apache/incubator-superset/pull/11160#issuecomment-705739251


   @kgabryje I posed this question to designers (admittedly, internal ones... the broader community is welcome to engage here!), and got some feedback:
   
   The technical constraints, requiring the use of the card-style tabs here are acknowledged. The design perspective, however, is that we should limit the number of _visible_ tab styles in our design system. The preferred approach would be to use these card-based tabs, but restyle them so they have a more consistent _appearance_ with the underlined tabs we use elsewhere.
   
   I don't believe it should block this PR, as I think this PR is a big step in the right direction. A PR in which we re-style the various AntD tab flavors to be more consistent seems like a worthy follow-up task.
   
   Curious how others feel about that proposal.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org