You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by gi...@git.apache.org on 2017/08/10 18:40:49 UTC

[GitHub] merlimat opened a new pull request #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ?

merlimat opened a new pull request #673: Fix #657: Use exceptions instead of assert() to do runtime parameter ?
URL: https://github.com/apache/incubator-pulsar/pull/673
 
 
   ?validations
   
   ### Motivation
   
   Since we use the Release profile to compile in the `pulsar-master` Jenkins build, CMake is passing the `-DNDEBUG` macro which remove the assertions.
   
   The ProducerConfiguration test was failing because it was excepting the process to be aborted because of the assertion failure, but that is no longer the case in release build. 
   
   This is causing the master builds to fail.
   
   ### Modifications
   
   As in other places, throw an exception when some configuration parameters are not valid.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services