You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2012/11/26 15:56:58 UTC

[jira] [Created] (FELIX-3785) [PATCH] debug logging of lock operations in Felix class

Bertrand Delacretaz created FELIX-3785:
------------------------------------------

             Summary: [PATCH] debug logging of lock operations in Felix class
                 Key: FELIX-3785
                 URL: https://issues.apache.org/jira/browse/FELIX-3785
             Project: Felix
          Issue Type: Improvement
          Components: Framework
    Affects Versions: framework-4.0.2
            Reporter: Bertrand Delacretaz
            Priority: Minor


I've added some debug logging to the Felix class to help follow global/bundle/install lock/unlock operations, will attach the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3785) [PATCH] debug logging of lock operations in Felix class

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz updated FELIX-3785:
---------------------------------------

    Attachment: FELIX-3785.patch
    
> [PATCH] debug logging of lock operations in Felix class
> -------------------------------------------------------
>
>                 Key: FELIX-3785
>                 URL: https://issues.apache.org/jira/browse/FELIX-3785
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-4.0.2
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: FELIX-3785.patch
>
>
> I've added some debug logging to the Felix class to help follow global/bundle/install lock/unlock operations, will attach the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3785) [PATCH] debug logging of lock operations in Felix class

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507195#comment-13507195 ] 

Bertrand Delacretaz commented on FELIX-3785:
--------------------------------------------

I see - I wasn't aware of this issue, and I suspect the same problem might be present in other classes that log while locks are being held.

Anyway, I agree that this should be avoided in this class, how about using a framework property to disable those logs by default, like the existing ds.loglevel one?
                
> [PATCH] debug logging of lock operations in Felix class
> -------------------------------------------------------
>
>                 Key: FELIX-3785
>                 URL: https://issues.apache.org/jira/browse/FELIX-3785
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-4.0.2
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: FELIX-3785.patch
>
>
> I've added some debug logging to the Felix class to help follow global/bundle/install lock/unlock operations, will attach the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3785) [PATCH] debug logging of lock operations in Felix class

Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507097#comment-13507097 ] 

Richard S. Hall commented on FELIX-3785:
----------------------------------------

The main issue I see with this patch is that it logs while holding locks. It prevents us from pretty much ever using external loggers. Not that this is too big of a deal, since this issue has been with us for quite a while, which is why we don't log to a Log Service if one is present, since we were getting into deadlocks.
                
> [PATCH] debug logging of lock operations in Felix class
> -------------------------------------------------------
>
>                 Key: FELIX-3785
>                 URL: https://issues.apache.org/jira/browse/FELIX-3785
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-4.0.2
>            Reporter: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: FELIX-3785.patch
>
>
> I've added some debug logging to the Felix class to help follow global/bundle/install lock/unlock operations, will attach the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira