[GitHub] [cloudstack] shwstppr commented on a change in pull request #5387: api: fix NPE with deployVirtualMachine when null boottype

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #5387:
URL: https://github.com/apache/cloudstack/pull/5387#discussion_r699013817



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -293,7 +292,8 @@ public Long getDomainId() {
             }
         }
         if (ApiConstants.BootType.UEFI.equals(getBootType())) {

Review comment:
       Not sure abt this as in UI we allow empty boot mode and if we are skipping here, we will have to handle UI better by not allowing empty boot mode when UEFI is selected as boot type. Otherwise, user will expect VM to boot with UEFI just by changing the boot type.
   @rhtyd @nvazquez @davidjumani any comments on the behaviour?
   I feel maybe we should just handle the NPE in 4.15 and refactor boot options handling in UI & API in a separate PR for 4.16




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org