You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/18 01:01:43 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7448: [AIRFLOW-6828]
Stop using the zope library
mik-laj opened a new pull request #7448: [AIRFLOW-6828] Stop using the zope library
URL: https://github.com/apache/airflow/pull/7448
In very many places, we use a native method to report a deprecation warning.
```
01:53 $ git ls-files |grep -v "tests/" | xargs grep -l DeprecationWarning | wc -l
318
```
On other hands, zope deprecation is used in two files only, so I think we should abandon the use of this library to unify the code.
The native method is also better supported by the IDE.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7448: [AIRFLOW-6828] Stop
using the zope library
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7448: [AIRFLOW-6828] Stop using the zope library
URL: https://github.com/apache/airflow/pull/7448#issuecomment-587265175
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7448?src=pr&el=h1) Report
> Merging [#7448](https://codecov.io/gh/apache/airflow/pull/7448?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9cbd7de6d115795aba8bfb8addb060bfdfbdf87b?src=pr&el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `87.87%`.
[](https://codecov.io/gh/apache/airflow/pull/7448?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7448 +/- ##
==========================================
- Coverage 86.37% 86.19% -0.18%
==========================================
Files 877 877
Lines 41221 41260 +39
==========================================
- Hits 35603 35566 -37
- Misses 5618 5694 +76
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7448?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../microsoft/azure/hooks/azure\_container\_instance.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL2hvb2tzL2F6dXJlX2NvbnRhaW5lcl9pbnN0YW5jZS5weQ==) | `65.38% <33.33%> (-2.62%)` | :arrow_down: |
| [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `88.02% <93.33%> (+0.01%)` | :arrow_up: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.9% <0%> (-0.83%)` | :arrow_down: |
| [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.51% <0%> (-0.15%)` | :arrow_down: |
| [...viders/docker/example\_dags/example\_docker\_swarm.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL2V4YW1wbGVfZGFncy9leGFtcGxlX2RvY2tlcl9zd2FybS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...ow/providers/docker/example\_dags/example\_docker.py](https://codecov.io/gh/apache/airflow/pull/7448/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL2V4YW1wbGVfZGFncy9leGFtcGxlX2RvY2tlci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7448?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7448?src=pr&el=footer). Last update [9cbd7de...a390889](https://codecov.io/gh/apache/airflow/pull/7448?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7448: [AIRFLOW-6828] Stop
using the zope library
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7448: [AIRFLOW-6828] Stop using the zope library
URL: https://github.com/apache/airflow/pull/7448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on a change in pull request #7448:
[AIRFLOW-6828] Stop using the zope library
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7448: [AIRFLOW-6828] Stop using the zope library
URL: https://github.com/apache/airflow/pull/7448#discussion_r380640953
##########
File path: setup.py
##########
@@ -500,7 +500,6 @@ def do_setup():
'tzlocal>=1.4,<2.0.0',
'unicodecsv>=0.14.1',
'werkzeug<1.0.0',
- 'zope.deprecation>=4.0, <5.0',
Review comment:
> IF you are removing dependencies from this list, please make sure that you also increase
> DEPENDENCIES_EPOCH_NUMBER in the Dockerfile
See note above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7448:
[AIRFLOW-6828] Stop using the zope library
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7448: [AIRFLOW-6828] Stop using the zope library
URL: https://github.com/apache/airflow/pull/7448#discussion_r380823778
##########
File path: setup.py
##########
@@ -500,7 +500,6 @@ def do_setup():
'tzlocal>=1.4,<2.0.0',
'unicodecsv>=0.14.1',
'werkzeug<1.0.0',
- 'zope.deprecation>=4.0, <5.0',
Review comment:
I bumped the number. Thanls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services