You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by 陈兴春 <ch...@analysys.com.cn> on 2019/12/11 03:12:19 UTC

re:[Proposal] Improve CI / CD process

Hi xiaochun:
  I have 2 questions:
   1. I want to know how github actions execute api test and performance test, whether to send test reports, how to set environment variables in the interface
   2. Do I think I should prepare 2 sets of environment, at least wait for the api test to pass before deploying to the demo environment






原始邮件
发件人:Xiaochun Liuliuxiaochun@apache.org
收件人:devdev@dolphinscheduler.apache.org
发送时间:2019年12月9日(周一) 20:47
主题:[Proposal] Improve CI / CD process




Hi,
 all, the CI / CD process in DolphinScheduler only has build check and license check. The other parts are missing now.


Here is my proposal:
The overall idea of ​​CI / CD is shown in the following graph. There are two main triggering methods, submitting PR / MR trigger and night time trigger. The night time trigger triggers to run once a day, and the task is relatively heavy.
The content of CI / CD to be tested or checked is shown in thegraphbelow.




The above is my overall thinking. The details of the CI / CD plan for the next version are as follows:
 1) The ut needs to be improved. The goal of the proportion of UT is to reach 60%. At least the newly added PR cannot be lower than this. If it feels unreasonable, we can vote to discuss it. The modules involved in this supplementary UT are api server, common, alert, and some master and worker UTs.
 2) checkstyle check, there are two kinds of google and Alibaba, personal preference is alibaba (more comprehensive), this can be discussed separately
 3) spotbugs check
 4) Front-end eslint check
 5) Coveralls code coverage report. When submitting a PR, it will be automatically displayed in the comments, showing the impact of the new part on the current code coverage, and the current test coverage will be displayed on the github home page.


If have other ideas, we can discuss together ~~ Thank you


Xiaochun Liu
liuxiaochun@apache.org