You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/04 08:41:45 UTC

[GitHub] [airflow] RagingPuppies commented on a diff in pull request #28034: Added custom environment variables to statsd

RagingPuppies commented on code in PR #28034:
URL: https://github.com/apache/airflow/pull/28034#discussion_r1038930430


##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -115,6 +115,10 @@ spec:
             - name: config
               mountPath: /etc/statsd-exporter/mappings.yml
               subPath: mappings.yml
+{{- if .Values.statsd.env}}
+          env:
+          {{- include "container_extra_envs" (list . .Values.statsd.env) | indent 10 }}

Review Comment:
   @jedcunningham as Flower is not an airflow container as well, but it did use the same code, don't you think it should be aligned?
   
   https://github.com/apache/airflow/blob/8f98bfeb5372c7f61c77f081afb9b277c35b88ed/chart/templates/flower/flower-deployment.yaml#L142
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org