You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2020/08/24 15:28:14 UTC

[GitHub] [wicket] eozmen410 edited a comment on pull request #442: [WICKET-6805] Add Cross-Origin Opener Policy and Cross-Origin Embedder Policy support

eozmen410 edited a comment on pull request #442:
URL: https://github.com/apache/wicket/pull/442#issuecomment-679196121


   > IMHO the additions to Application would be better located in WebApplication#internalInit().
   > CSP is enforced there too.
   
   AFAICT the `internalInit()` method is called before `init()`, since we expect the users to configure their policies for COOP and COEP in the `init()` method, and we will add the listeners with the configs if they are not `DISABLED`, if we move the `secuirtyInit()` to `WebApplication#internalInit()` the configuration decisions made by the user in their `WebApplication#init()` will not have an effect on listener behavior. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org