You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/11/01 03:28:24 UTC

Review Request 27460: HIVE-8693: Separate out fair scheduler dependency from hadoop 0.23 shim

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27460/
-----------------------------------------------------------

Review request for hive, Brock Noland and Mohit Sabharwal.


Bugs: HIVE-8693
    https://issues.apache.org/jira/browse/HIVE-8693


Repository: hive-git


Description
-------

- Seperate out the fair sheduler code to a new module
- load the new module only for HS2 with fair scheduler configured


Diffs
-----

  shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 0a6abd8 
  shims/aggregator/pom.xml 5f76e84 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/SchedulerShim.java PRE-CREATION 
  shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java f354fb7 
  shims/pom.xml 7027126 
  shims/scheduler/pom.xml PRE-CREATION 
  shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java PRE-CREATION 

Diff: https://reviews.apache.org/r/27460/diff/


Testing
-------


Thanks,

Prasad Mujumdar


Re: Review Request 27460: HIVE-8693: Separate out fair scheduler dependency from hadoop 0.23 shim

Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27460/#review59609
-----------------------------------------------------------

Ship it!



shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java
<https://reviews.apache.org/r/27460/#comment100906>

    missing trailing 'S'



shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java
<https://reviews.apache.org/r/27460/#comment100907>

    missing trailing 'S'


- Mohit Sabharwal


On Nov. 1, 2014, 2:28 a.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27460/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 2:28 a.m.)
> 
> 
> Review request for hive, Brock Noland and Mohit Sabharwal.
> 
> 
> Bugs: HIVE-8693
>     https://issues.apache.org/jira/browse/HIVE-8693
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> - Seperate out the fair sheduler code to a new module
> - load the new module only for HS2 with fair scheduler configured
> 
> 
> Diffs
> -----
> 
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 0a6abd8 
>   shims/aggregator/pom.xml 5f76e84 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/SchedulerShim.java PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java f354fb7 
>   shims/pom.xml 7027126 
>   shims/scheduler/pom.xml PRE-CREATION 
>   shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27460/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>


Re: Review Request 27460: HIVE-8693: Separate out fair scheduler dependency from hadoop 0.23 shim

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27460/#review59540
-----------------------------------------------------------

Ship it!


Ship It!

- Brock Noland


On Nov. 1, 2014, 2:28 a.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27460/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 2:28 a.m.)
> 
> 
> Review request for hive, Brock Noland and Mohit Sabharwal.
> 
> 
> Bugs: HIVE-8693
>     https://issues.apache.org/jira/browse/HIVE-8693
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> - Seperate out the fair sheduler code to a new module
> - load the new module only for HS2 with fair scheduler configured
> 
> 
> Diffs
> -----
> 
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 0a6abd8 
>   shims/aggregator/pom.xml 5f76e84 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/SchedulerShim.java PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java f354fb7 
>   shims/pom.xml 7027126 
>   shims/scheduler/pom.xml PRE-CREATION 
>   shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27460/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>