You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/09 12:37:27 UTC
[GitHub] [phoenix] stoty opened a new pull request #727: PHOENIX-5762 Update
jackson
stoty opened a new pull request #727: PHOENIX-5762 Update jackson
URL: https://github.com/apache/phoenix/pull/727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] joshelser commented on a change in pull request #727:
PHOENIX-5762 Update jackson
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #727: PHOENIX-5762 Update jackson
URL: https://github.com/apache/phoenix/pull/727#discussion_r389805269
##########
File path: pom.xml
##########
@@ -87,7 +87,7 @@
<!-- Dependency versions -->
<commons-cli.version>1.4</commons-cli.version>
- <jackson.version>1.9.2</jackson.version>
+ <jackson.version>2.10.3</jackson.version>
Review comment:
We don't store any jackson-serialized data anywhere, right? The file change list looks like it's not persisted (just used in processing and then thrown away).
I'd be concerned about serde compatibility issues from Jackson 1.x to 2.x, but hopefully that is not a concern at all if we're not holding on to that data anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] mihir6692 commented on issue #727: PHOENIX-5762 Update
jackson
Posted by GitBox <gi...@apache.org>.
mihir6692 commented on issue #727: PHOENIX-5762 Update jackson
URL: https://github.com/apache/phoenix/pull/727#issuecomment-596536112
lgtm +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] stoty commented on a change in pull request #727:
PHOENIX-5762 Update jackson
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #727: PHOENIX-5762 Update jackson
URL: https://github.com/apache/phoenix/pull/727#discussion_r389862902
##########
File path: pom.xml
##########
@@ -87,7 +87,7 @@
<!-- Dependency versions -->
<commons-cli.version>1.4</commons-cli.version>
- <jackson.version>1.9.2</jackson.version>
+ <jackson.version>2.10.3</jackson.version>
Review comment:
We only use jackson in the three files that are touched in this commit.
For deserializing JSON data that we bulk load, and for serializing the output of the trace servlet for the tracing webapp.
Neither is persisted anywhere (well, not in JSON form anyway)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services