You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2012/12/01 21:22:29 UTC

Re: Review Request: Update samples to use new fields added in OpenSocial 2.5

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8267/#review13945
-----------------------------------------------------------


Looks good to me for the most part but I will admit I don't know too much about JPA :)

A few small things...

Can you add the JIRA to the bug field on the review?  It should automatically link out to it.

Please remove all the extra whitespace (shown in red in the review) from the patch.

Some of the classes have JavaDoc and your new methods do not have any, could you please JavaDoc the methods in the classes that have JavaDoc?

- Ryan Baxter


On Nov. 29, 2012, 11:17 a.m., Jan Willem Janssen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8267/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 11:17 a.m.)
> 
> 
> Review request for shindig, Henry Saputra and Ryan Baxter.
> 
> 
> Description
> -------
> 
> Patch for the Social API sample implementation regarding SHINDIG-1878.
> 
> 
> Diffs
> -----
> 
>   trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/AddressDb.java 1415078 
>   trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/NameDb.java 1415078 
>   trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/OrganizationDb.java 1415078 
>   trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/PersonDb.java 1415078 
> 
> Diff: https://reviews.apache.org/r/8267/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Willem Janssen
> 
>