You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/13 10:39:57 UTC

[GitHub] [flink] wangxlong opened a new pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

wangxlong opened a new pull request #13612:
URL: https://github.com/apache/flink/pull/13612


   
   ## What is the purpose of the change
   
   Fix error result when casting binary as varchar
   
   
   ## Brief change log
   
   Add binary to varchar cast case
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   ScalarFunctionsTest#testCast
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no / don't know)
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518) 
   * 929b3b31e8274262fb1ca85af2dfac8a235cb403 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangxlong commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wangxlong commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-710026458


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangxlong commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wangxlong commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-710026347


   Rebase the master for the build failed in pubsub connector e2e test whitch has be disabled in master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 929b3b31e8274262fb1ca85af2dfac8a235cb403 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530) 
   * 982af6445d2f917e952dac847238f5dfb6f66f96 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13612:
URL: https://github.com/apache/flink/pull/13612


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) 
   * a1a881b34bea5ede3b622e0d53c9728d232cb48c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424",
       "triggerID" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8438",
       "triggerID" : "717649160",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424",
       "triggerID" : "717649160",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 046d675d2c1255d2f0c9cd919fe3abc065bdcf9a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8438) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13612:
URL: https://github.com/apache/flink/pull/13612#discussion_r503853427



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -4056,4 +4056,15 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "f55=f57",
       "true")
   }
+
+  @Test
+  def testCast(): Unit = {

Review comment:
       Could you add this test to `ScalarOperatorsTest`? Because `cast` is an operator. 
   Besides, coul dyou add cast tests for binary and varbinary source fields?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangxlong commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wangxlong commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-717649160


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangxlong commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wangxlong commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-714452462


   Hi @wuchong , Thank you for reviewing again in your free time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518) 
   * 929b3b31e8274262fb1ca85af2dfac8a235cb403 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707654333


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d (Tue Oct 13 10:41:44 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518) 
   * 929b3b31e8274262fb1ca85af2dfac8a235cb403 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangxlong commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wangxlong commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-709776316


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 929b3b31e8274262fb1ca85af2dfac8a235cb403 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530) 
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a1a881b34bea5ede3b622e0d53c9728d232cb48c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758) 
   * 046d675d2c1255d2f0c9cd919fe3abc065bdcf9a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-717719113


   Build is passed: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=8438&view=results
   Merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a1a881b34bea5ede3b622e0d53c9728d232cb48c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangxlong commented on a change in pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #13612:
URL: https://github.com/apache/flink/pull/13612#discussion_r512773089



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarOperatorsTest.scala
##########
@@ -62,6 +62,26 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
     )
   }
 
+  @Test
+  def testCast(): Unit = {
+
+    // binary -> varchar
+    testSqlApi(
+      "CAST (f18 as varchar)",
+      "hello world")
+
+    // varbinary -> varchar
+    testSqlApi(
+      "CAST (f19 as varchar)",
+      "hello flink")
+
+    // null case
+    testSqlApi("CAST (NULL AS INT)", "null")
+    testSqlApi(
+      "CAST (NULL AS VARCHAR) = ''",
+      "null")

Review comment:
       Updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424",
       "triggerID" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8438",
       "triggerID" : "717649160",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 046d675d2c1255d2f0c9cd919fe3abc065bdcf9a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8438) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424",
       "triggerID" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a1a881b34bea5ede3b622e0d53c9728d232cb48c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758) 
   * 046d675d2c1255d2f0c9cd919fe3abc065bdcf9a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424",
       "triggerID" : "046d675d2c1255d2f0c9cd919fe3abc065bdcf9a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 046d675d2c1255d2f0c9cd919fe3abc065bdcf9a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8424) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) 
   * a1a881b34bea5ede3b622e0d53c9728d232cb48c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7758) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangxlong commented on a change in pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #13612:
URL: https://github.com/apache/flink/pull/13612#discussion_r503923211



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -4056,4 +4056,15 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "f55=f57",
       "true")
   }
+
+  @Test
+  def testCast(): Unit = {

Review comment:
       Yes, Thank you for reminder. I updated the test case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #13612:
URL: https://github.com/apache/flink/pull/13612#discussion_r512412637



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarOperatorsTest.scala
##########
@@ -62,6 +62,26 @@ class ScalarOperatorsTest extends ScalarOperatorsTestBase {
     )
   }
 
+  @Test
+  def testCast(): Unit = {
+
+    // binary -> varchar
+    testSqlApi(
+      "CAST (f18 as varchar)",
+      "hello world")
+
+    // varbinary -> varchar
+    testSqlApi(
+      "CAST (f19 as varchar)",
+      "hello flink")
+
+    // null case
+    testSqlApi("CAST (NULL AS INT)", "null")
+    testSqlApi(
+      "CAST (NULL AS VARCHAR) = ''",
+      "null")

Review comment:
       Would be better to add a test for cast binary literal to varchar. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "triggerType" : "PUSH"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691",
       "triggerID" : "709776316",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "982af6445d2f917e952dac847238f5dfb6f66f96",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722",
       "triggerID" : "710026458",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a1a881b34bea5ede3b622e0d53c9728d232cb48c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 982af6445d2f917e952dac847238f5dfb6f66f96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7691) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7756) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7722) 
   * a1a881b34bea5ede3b622e0d53c9728d232cb48c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13612: [FLINK-19587][table-planner-blink] Fix error result when casting binary as varchar

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13612:
URL: https://github.com/apache/flink/pull/13612#issuecomment-707667105


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7518",
       "triggerID" : "0aeb2e48d1722fab6e1a52ab64d3c8bd5665048d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530",
       "triggerID" : "929b3b31e8274262fb1ca85af2dfac8a235cb403",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 929b3b31e8274262fb1ca85af2dfac8a235cb403 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7530) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org