You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by rjbriody <gi...@git.apache.org> on 2016/03/21 14:27:26 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...
GitHub user rjbriody opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/273
TINKERPOP-1199:Use "MicroMetrics" as the mutator of the TraversalMetrics.
https://issues.apache.org/jira/browse/TINKERPOP-1199
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rjbriody/incubator-tinkerpop TINKERPOP-1199
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit e73bbc5d978432e09e0323509854bed5cb7ee08f
Author: rjbriody <bo...@datastax.com>
Date: 2016-03-17T21:13:34Z
profiling overhaul.
commit 3f25710b10301432ea64996330a084872d8bc78f
Author: rjbriody <bo...@datastax.com>
Date: 2016-03-17T21:38:26Z
Don't profile computer steps.
commit 800cf0a46cf3d991c28aeb174f9692c0d6fa3f71
Author: rjbriody <bo...@datastax.com>
Date: 2016-03-17T21:52:31Z
Add play test for computer profile
commit 581f33bcb8aef7ff76e31175b0b0fcdc5059bba7
Author: rjbriody <bo...@datastax.com>
Date: 2016-03-21T13:04:32Z
Put back check to prevent profiling of computer traversals.
commit 5b6acfc754ba7b5f50942b607786fe00bf6ef020
Author: rjbriody <bo...@datastax.com>
Date: 2016-03-21T13:07:21Z
Revert "Don't profile computer steps."
This reverts commit 3f25710b10301432ea64996330a084872d8bc78f.
commit 73b2d42a5d0ebe9091fb300db9e5ca01206f4e45
Author: rjbriody <bo...@datastax.com>
Date: 2016-03-21T13:24:37Z
merge master
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...
Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199908876
Cool work guys. This makes a lot of sense functionally. It's a nice bonus that you caught that issue in the middle of it.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199418665
This has been merged to a local `TINKERPOP-1199` branch as more work still needs to be done. Will put up for VOTE via a PR from the local branch after @rjbriody and I get this all squared away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-200006533
Looks good, VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199886276
Here is the complete branch: https://github.com/apache/incubator-tinkerpop/tree/TINKERPOP-1199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1199:Use "MicroMetrics...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/273#issuecomment-199883620
This is ready to VOTE. The completed branch is actually TINKERPOP-1199 locally (not in @rjbriody's repository anymore). I can't seem to make a PR from that our local branch as doing so just links me to this ticket. Don't know how that effects VOTERs and their testing ? --- just be aware.
In short, profiling and the new sideEffect/memory model of GraphComputer have been reconciled. This was painful as profiling is a very complicated/intrusive system. However, getting it to work with the new memory-model in OLAP is a strong testament to the flexibility of the changes forthcoming in 3.2.0 OLAP. Bob and I added lots more testing as well. Also, there was a severe bug found in `ComputerVerificationStrategy` that has since been rectified (a profile test exposed it).
CHANGELOG
```
* Fixed a bug around profiling and nested traversals.
```
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---