You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/31 17:46:18 UTC
[GitHub] [incubator-mxnet] ptrendx opened a new pull request #17946: Change
register_op_hook to take MXNet and Python types instead of C types
ptrendx opened a new pull request #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946
## Description ##
This PR changes the API of the Gluon's `register_op_hook` method to take the Python strings and MXNet NDArray instead of the C string and internal NDArrayHandle. Also it fixes a bug in the documentation (which previously said that the function should take 2 parameters, whereas in fact it takes 3).
This change makes the `register_op_hook` much more user-friendly, especially for people not familiar with MXNet internals.
@szha @eric-haibin-lin @anirudh2290
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
ptrendx commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-606844656
This PR goes to master (so to 2.0), I don't think that we want breaking changes in 1.x/1.7 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
ptrendx commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-614739561
@mxnet-bot run ci [unix-gpu]
Timeouts :-(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-614739619
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-609941907
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-611747337
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-612234494
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
ptrendx commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-611747274
@mxnet-bot run ci [unix-gpu, unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
ptrendx commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-609941845
@mxnet-bot run ci [unix-gpu, unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-606775774
Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, windows-cpu, windows-gpu, edge, clang, unix-gpu, sanity, miscellaneous, unix-cpu, centos-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on issue #17946: Change
register_op_hook to take MXNet and Python types instead of C types
Posted by GitBox <gi...@apache.org>.
ptrendx commented on issue #17946: Change register_op_hook to take MXNet and Python types instead of C types
URL: https://github.com/apache/incubator-mxnet/pull/17946#issuecomment-612234452
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services