You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/02/27 17:55:55 UTC
[GitHub] couchdb-fauxton pull request: Extract common react components
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/295
Extract common react components
- extract components: header-toggle-button-component
- extract components: styled-select component
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton componentize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit b34a64eb78167a95ba767125fb15a236404c87b7
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-02-27T13:02:14Z
extract components: header-toggle-button-component
commit a85eb42a1283c3fd5a69864eea466c7368b0b2e0
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-02-27T16:43:54Z
extract components: styled-select component
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Extract common react components
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Extract common react components
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/295#issuecomment-76749775
I have some mixed feelings regarding that, let's talk tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Extract common react components
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/295#issuecomment-76722083
+1 this is awesome. We could also add the general components to something like `Fauxton.components.StyledSelect` so we can use them anywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---