[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4338: Move BooleanBufferBuilder and NullBufferBuilder to arrow_buffer

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4338:
URL: https://github.com/apache/arrow-rs/pull/4338#discussion_r1213346876


##########
arrow-buffer/src/builder/null.rs:
##########
@@ -128,10 +127,15 @@ impl NullBufferBuilder {
 
     /// Builds the null buffer and resets the builder.
     /// Returns `None` if the builder only contains `true`s.
-    pub fn finish(&mut self) -> Option<Buffer> {
-        let buf = self.bitmap_builder.take().map(Into::into);
+    pub fn finish(&mut self) -> Option<NullBuffer> {

Review Comment:
   As this was previously crate-private I took the opportunity to change the signature before it becomes public and changing would be a breaking change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org