You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/19 21:53:57 UTC
[GitHub] [beam] suztomo opened a new pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
suztomo opened a new pull request #14025:
URL: https://github.com/apache/beam/pull/14025
Attempt to see where it breaks when upgrading the vendored gRPC from 1.26 to 1.35.
Previous upgrade: https://github.com/apache/beam/pull/10578/files.
The first step in https://github.com/apache/beam/blob/master/vendor/README.md
```
# Vendored Dependencies Release
The upgrading of the vendored dependencies should be performed in two steps:
- Firstly, we need to perform a formal release of the vendored dependency.
The [release process](http://s.apache.org/beam-release-vendored-artifacts) of the vendored dependency
is separate from the release of Apache Beam.
- When the release of the vendored dependency is out, we can migrate Apache Beam to use the newly released
vendored dependency.
```
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782398825
# [Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=h1) Report
> Merging [#14025](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=desc) (8607ebe) into [master](https://codecov.io/gh/apache/beam/commit/edae900d0e3b68e80f0a4ff7724f8f081be0af6e?el=desc) (edae900) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14025 +/- ##
==========================================
- Coverage 82.97% 82.97% -0.01%
==========================================
Files 469 469
Lines 58294 58294
==========================================
- Hits 48371 48369 -2
- Misses 9923 9925 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.26%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.54% <0.00%> (-0.16%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `92.42% <0.00%> (+0.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=footer). Last update [6e4adca...8607ebe](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo edited a comment on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
suztomo edited a comment on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782395559
It failed. https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/16108/console
```
21:56:17 > Task :sdks:java:core:compileJava
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:49: error: cannot access GeneratedMessageV3
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MIN_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3 not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:58: error: cannot access MessageOrBuilder
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MAX_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.MessageOrBuilder not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access GeneratedMessage
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessage not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access ProtocolMessageEnum
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ProtocolMessageEnum not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access Descriptors
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.Descriptors not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:711: error: cannot access Builder
21:56:17 .setName(optionName)
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3$Builder not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:154: error: cannot access ByteString
21:56:21 logicalTypeBuilder.setPayload(
21:56:21 ^
21:56:21 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:454: error: incompatible types: org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString cannot be converted to org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString
21:56:21 return AtomicTypeValue.newBuilder().setBytes(ByteString.copyFrom((byte[]) value)).build();
21:56:21 ^
21:56:22 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:71: error: cannot find symbol
21:56:22 schemaProtoRepresentation = SchemaTranslation.schemaToProto(oneOfSchema, false).toByteArray();
21:56:22 ^
21:56:22 symbol: method toByteArray()
21:56:22 location: class Schema
21:56:38 error: AnnotatedTypeMirror.createType: input is not compilable. Found error type: <any>
21:56:38 ; The Checker Framework crashed. Please report the crash.
21:56:38 Compilation unit: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java
21:56:38 Last visited tree at line 38 column 1:
21:56:38 public abstract class BoundedWindow {
21:56:38 Exception: java.lang.Throwable; java.lang.Throwable
21:56:38 at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:16)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeMirror.createType(AnnotatedTypeMirror.java:77)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.toAnnotatedType(AnnotatedTypeFactory.java:3069)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.type(AnnotatedTypeFactory.java:3088)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:319)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:50)
21:56:38 at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2112)
21:56:38 at com.sun.source.util.SimpleTreeVisitor.visit(SimpleTreeVisitor.java:80)
21:56:38 at org.checkerframework.framework.type.TypeFromTree.fromTypeTree(TypeFromTree.java:78)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.fromTypeTree(AnnotatedTypeFactory.java:1371)
21:56:38 at
```
What does `cannot access GeneratedMessageV3` mean? BeamConstants is a subclass of GeneratedMessageV3.
`public static final class BeamConstants extends GeneratedMessageV3 implements RunnerApi.BeamConstantsOrBuilder`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo edited a comment on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
suztomo edited a comment on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782395559
It failed. https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/16108/console
```
21:56:17 > Task :sdks:java:core:compileJava
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:49: error: cannot access GeneratedMessageV3
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MIN_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3 not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:58: error: cannot access MessageOrBuilder
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MAX_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.MessageOrBuilder not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access GeneratedMessage
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessage not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access ProtocolMessageEnum
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ProtocolMessageEnum not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access Descriptors
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.Descriptors not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:711: error: cannot access Builder
21:56:17 .setName(optionName)
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3$Builder not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:154: error: cannot access ByteString
21:56:21 logicalTypeBuilder.setPayload(
21:56:21 ^
21:56:21 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:454: error: incompatible types: org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString cannot be converted to org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString
21:56:21 return AtomicTypeValue.newBuilder().setBytes(ByteString.copyFrom((byte[]) value)).build();
21:56:21 ^
21:56:22 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:71: error: cannot find symbol
21:56:22 schemaProtoRepresentation = SchemaTranslation.schemaToProto(oneOfSchema, false).toByteArray();
21:56:22 ^
21:56:22 symbol: method toByteArray()
21:56:22 location: class Schema
21:56:38 error: AnnotatedTypeMirror.createType: input is not compilable. Found error type: <any>
21:56:38 ; The Checker Framework crashed. Please report the crash.
21:56:38 Compilation unit: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java
21:56:38 Last visited tree at line 38 column 1:
21:56:38 public abstract class BoundedWindow {
21:56:38 Exception: java.lang.Throwable; java.lang.Throwable
21:56:38 at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:16)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeMirror.createType(AnnotatedTypeMirror.java:77)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.toAnnotatedType(AnnotatedTypeFactory.java:3069)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.type(AnnotatedTypeFactory.java:3088)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:319)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:50)
21:56:38 at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2112)
21:56:38 at com.sun.source.util.SimpleTreeVisitor.visit(SimpleTreeVisitor.java:80)
21:56:38 at org.checkerframework.framework.type.TypeFromTree.fromTypeTree(TypeFromTree.java:78)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.fromTypeTree(AnnotatedTypeFactory.java:1371)
21:56:38 at
```
What does `cannot access GeneratedMessageV3` mean? BeamConstants is a subclass of GeneratedMessageV3.
`public static final class BeamConstants extends GeneratedMessageV3 implements RunnerApi.BeamConstantsOrBuilder`.
GeneratedMessageV3 is a public class available in protobuf-java:3.14.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo closed pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
suztomo closed pull request #14025:
URL: https://github.com/apache/beam/pull/14025
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo edited a comment on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
suztomo edited a comment on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782395559
It failed. https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/16108/console
```
21:56:17 > Task :sdks:java:core:compileJava
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:49: error: cannot access GeneratedMessageV3
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MIN_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3 not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:58: error: cannot access MessageOrBuilder
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MAX_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.MessageOrBuilder not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access GeneratedMessage
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessage not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access ProtocolMessageEnum
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ProtocolMessageEnum not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access Descriptors
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.Descriptors not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:711: error: cannot access Builder
21:56:17 .setName(optionName)
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3$Builder not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:154: error: cannot access ByteString
21:56:21 logicalTypeBuilder.setPayload(
21:56:21 ^
21:56:21 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:454: error: incompatible types: org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString cannot be converted to org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString
21:56:21 return AtomicTypeValue.newBuilder().setBytes(ByteString.copyFrom((byte[]) value)).build();
21:56:21 ^
21:56:22 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:71: error: cannot find symbol
21:56:22 schemaProtoRepresentation = SchemaTranslation.schemaToProto(oneOfSchema, false).toByteArray();
21:56:22 ^
21:56:22 symbol: method toByteArray()
21:56:22 location: class Schema
21:56:38 error: AnnotatedTypeMirror.createType: input is not compilable. Found error type: <any>
21:56:38 ; The Checker Framework crashed. Please report the crash.
21:56:38 Compilation unit: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java
21:56:38 Last visited tree at line 38 column 1:
21:56:38 public abstract class BoundedWindow {
21:56:38 Exception: java.lang.Throwable; java.lang.Throwable
21:56:38 at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:16)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeMirror.createType(AnnotatedTypeMirror.java:77)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.toAnnotatedType(AnnotatedTypeFactory.java:3069)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.type(AnnotatedTypeFactory.java:3088)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:319)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:50)
21:56:38 at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2112)
21:56:38 at com.sun.source.util.SimpleTreeVisitor.visit(SimpleTreeVisitor.java:80)
21:56:38 at org.checkerframework.framework.type.TypeFromTree.fromTypeTree(TypeFromTree.java:78)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.fromTypeTree(AnnotatedTypeFactory.java:1371)
21:56:38 at
```
What does `cannot access GeneratedMessageV3` mean? BeamConstants is a subclass of GeneratedMessageV3.
`public static final class BeamConstants extends GeneratedMessageV3 implements RunnerApi.BeamConstantsOrBuilder`.
GeneratedMessageV3 is a public class available in protobuf-java:3.14. The vendored gRPC has not yet been uploaded to Maven Central and this PR has not touched `shadow library.java.vendored_grpc_1_26_0` part in `sdks/java/core/build.gradle`. Why does this already try to get the classes in `org.apache.beam.vendor.grpc.v1p35p0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782398825
# [Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=h1) Report
> Merging [#14025](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=desc) (8607ebe) into [master](https://codecov.io/gh/apache/beam/commit/edae900d0e3b68e80f0a4ff7724f8f081be0af6e?el=desc) (edae900) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14025 +/- ##
==========================================
- Coverage 82.97% 82.97% -0.01%
==========================================
Files 469 469
Lines 58294 58294
==========================================
- Hits 48371 48369 -2
- Misses 9923 9925 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.26%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.54% <0.00%> (-0.16%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `92.42% <0.00%> (+0.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=footer). Last update [6e4adca...8607ebe](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782398825
# [Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=h1) Report
> Merging [#14025](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=desc) (8607ebe) into [master](https://codecov.io/gh/apache/beam/commit/edae900d0e3b68e80f0a4ff7724f8f081be0af6e?el=desc) (edae900) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14025 +/- ##
==========================================
- Coverage 82.97% 82.97% -0.01%
==========================================
Files 469 469
Lines 58294 58294
==========================================
- Hits 48371 48369 -2
- Misses 9923 9925 +2
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.70% <0.00%> (-0.26%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.54% <0.00%> (-0.16%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/14025/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `92.42% <0.00%> (+0.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=footer). Last update [6e4adca...8607ebe](https://codecov.io/gh/apache/beam/pull/14025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo edited a comment on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
suztomo edited a comment on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782395559
It failed. https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/16108/console
```
21:56:17 > Task :sdks:java:core:compileJava
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:49: error: cannot access GeneratedMessageV3
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MIN_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3 not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:58: error: cannot access MessageOrBuilder
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MAX_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.MessageOrBuilder not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access GeneratedMessage
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessage not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access ProtocolMessageEnum
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ProtocolMessageEnum not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access Descriptors
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.Descriptors not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:711: error: cannot access Builder
21:56:17 .setName(optionName)
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3$Builder not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:154: error: cannot access ByteString
21:56:21 logicalTypeBuilder.setPayload(
21:56:21 ^
21:56:21 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:454: error: incompatible types: org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString cannot be converted to org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString
21:56:21 return AtomicTypeValue.newBuilder().setBytes(ByteString.copyFrom((byte[]) value)).build();
21:56:21 ^
21:56:22 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:71: error: cannot find symbol
21:56:22 schemaProtoRepresentation = SchemaTranslation.schemaToProto(oneOfSchema, false).toByteArray();
21:56:22 ^
21:56:22 symbol: method toByteArray()
21:56:22 location: class Schema
21:56:38 error: AnnotatedTypeMirror.createType: input is not compilable. Found error type: <any>
21:56:38 ; The Checker Framework crashed. Please report the crash.
21:56:38 Compilation unit: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java
21:56:38 Last visited tree at line 38 column 1:
21:56:38 public abstract class BoundedWindow {
21:56:38 Exception: java.lang.Throwable; java.lang.Throwable
21:56:38 at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:16)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeMirror.createType(AnnotatedTypeMirror.java:77)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.toAnnotatedType(AnnotatedTypeFactory.java:3069)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.type(AnnotatedTypeFactory.java:3088)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:319)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:50)
21:56:38 at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2112)
21:56:38 at com.sun.source.util.SimpleTreeVisitor.visit(SimpleTreeVisitor.java:80)
21:56:38 at org.checkerframework.framework.type.TypeFromTree.fromTypeTree(TypeFromTree.java:78)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.fromTypeTree(AnnotatedTypeFactory.java:1371)
21:56:38 at
```
What does `cannot access GeneratedMessageV3` mean? BeamConstants is a subclass of GeneratedMessageV3.
`public static final class BeamConstants extends GeneratedMessageV3 implements RunnerApi.BeamConstantsOrBuilder`.
GeneratedMessageV3 is a public class available in protobuf-java:3.14. The vendored gRPC has not yet been uploaded to Maven Central and this PR has not touched `shadow library.java.vendored_grpc_1_26_0` part in `sdks/java/core/build.gradle`.
Why does this already try to get the classes in `org.apache.beam.vendor.grpc.v1p35p0` package? Answer:
```
// GrpcVendoring_1_35_0
static Object shadowClosure() {
return {
relocations().each { srcNamespace, destNamespace ->
relocate srcNamespace, destNamespace
```
```
// BeamModuePlugin.groovy
shadowClosure: GrpcVendoring_1_35_0.shadowClosure() << {
// We perform all the code relocations but don't include
// any of the actual dependencies since they will be supplied
// by org.apache.beam:beam-vendor-grpc-v1p26p0:0.1
dependencies {
include(dependency { return false })
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo edited a comment on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
suztomo edited a comment on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782395559
It failed. https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/16108/console
```
21:56:17 > Task :sdks:java:core:compileJava
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:49: error: cannot access GeneratedMessageV3
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MIN_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3 not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:58: error: cannot access MessageOrBuilder
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MAX_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.MessageOrBuilder not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access GeneratedMessage
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessage not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access ProtocolMessageEnum
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ProtocolMessageEnum not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access Descriptors
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.Descriptors not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:711: error: cannot access Builder
21:56:17 .setName(optionName)
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3$Builder not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:154: error: cannot access ByteString
21:56:21 logicalTypeBuilder.setPayload(
21:56:21 ^
21:56:21 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:454: error: incompatible types: org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString cannot be converted to org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString
21:56:21 return AtomicTypeValue.newBuilder().setBytes(ByteString.copyFrom((byte[]) value)).build();
21:56:21 ^
21:56:22 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:71: error: cannot find symbol
21:56:22 schemaProtoRepresentation = SchemaTranslation.schemaToProto(oneOfSchema, false).toByteArray();
21:56:22 ^
21:56:22 symbol: method toByteArray()
21:56:22 location: class Schema
21:56:38 error: AnnotatedTypeMirror.createType: input is not compilable. Found error type: <any>
21:56:38 ; The Checker Framework crashed. Please report the crash.
21:56:38 Compilation unit: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java
21:56:38 Last visited tree at line 38 column 1:
21:56:38 public abstract class BoundedWindow {
21:56:38 Exception: java.lang.Throwable; java.lang.Throwable
21:56:38 at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:16)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeMirror.createType(AnnotatedTypeMirror.java:77)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.toAnnotatedType(AnnotatedTypeFactory.java:3069)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.type(AnnotatedTypeFactory.java:3088)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:319)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:50)
21:56:38 at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2112)
21:56:38 at com.sun.source.util.SimpleTreeVisitor.visit(SimpleTreeVisitor.java:80)
21:56:38 at org.checkerframework.framework.type.TypeFromTree.fromTypeTree(TypeFromTree.java:78)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.fromTypeTree(AnnotatedTypeFactory.java:1371)
21:56:38 at
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #14025: [BEAM-11227] Upgrading vendored gRPC from 1.26 to 1.35
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #14025:
URL: https://github.com/apache/beam/pull/14025#issuecomment-782395559
Failed
```
21:56:17 > Task :sdks:java:core:compileJava
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:49: error: cannot access GeneratedMessageV3
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MIN_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3 not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:58: error: cannot access MessageOrBuilder
21:56:17 extractTimestampFromProto(RunnerApi.BeamConstants.Constants.MAX_TIMESTAMP_MILLIS);
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.MessageOrBuilder not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access GeneratedMessage
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessage not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access ProtocolMessageEnum
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ProtocolMessageEnum not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java:84: error: cannot access Descriptors
21:56:17 constant.getValueDescriptor().getOptions().getExtension(RunnerApi.beamConstant)));
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.Descriptors not found
21:56:17 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java:711: error: cannot access Builder
21:56:17 .setName(optionName)
21:56:17 ^
21:56:17 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.GeneratedMessageV3$Builder not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:154: error: cannot access ByteString
21:56:21 logicalTypeBuilder.setPayload(
21:56:21 ^
21:56:21 class file for org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString not found
21:56:21 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaTranslation.java:454: error: incompatible types: org.apache.beam.vendor.grpc.v1p26p0.com.google.protobuf.ByteString cannot be converted to org.apache.beam.vendor.grpc.v1p35p0.com.google.protobuf.ByteString
21:56:21 return AtomicTypeValue.newBuilder().setBytes(ByteString.copyFrom((byte[]) value)).build();
21:56:21 ^
21:56:22 /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/OneOfType.java:71: error: cannot find symbol
21:56:22 schemaProtoRepresentation = SchemaTranslation.schemaToProto(oneOfSchema, false).toByteArray();
21:56:22 ^
21:56:22 symbol: method toByteArray()
21:56:22 location: class Schema
21:56:38 error: AnnotatedTypeMirror.createType: input is not compilable. Found error type: <any>
21:56:38 ; The Checker Framework crashed. Please report the crash.
21:56:38 Compilation unit: /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@3/src/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/BoundedWindow.java
21:56:38 Last visited tree at line 38 column 1:
21:56:38 public abstract class BoundedWindow {
21:56:38 Exception: java.lang.Throwable; java.lang.Throwable
21:56:38 at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:16)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeMirror.createType(AnnotatedTypeMirror.java:77)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.toAnnotatedType(AnnotatedTypeFactory.java:3069)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.type(AnnotatedTypeFactory.java:3088)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:319)
21:56:38 at org.checkerframework.framework.type.TypeFromTypeTreeVisitor.visitMemberSelect(TypeFromTypeTreeVisitor.java:50)
21:56:38 at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:2112)
21:56:38 at com.sun.source.util.SimpleTreeVisitor.visit(SimpleTreeVisitor.java:80)
21:56:38 at org.checkerframework.framework.type.TypeFromTree.fromTypeTree(TypeFromTree.java:78)
21:56:38 at org.checkerframework.framework.type.AnnotatedTypeFactory.fromTypeTree(AnnotatedTypeFactory.java:1371)
21:56:38 at
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org