You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/11/02 09:30:16 UTC
[GitHub] [james-project] ottoka opened a new pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
ottoka opened a new pull request #730:
URL: https://github.com/apache/james-project/pull/730
When the DSNBounce mailet processes a mail without a Date header, it fails with the exception
`java.time.temporal.UnsupportedTemporalTypeException: Unsupported field: OffsetSeconds`
because the LocalDateTime used to construct the new date does not include timezone information required by the date formatter.
The fix is to construct the new date via ZonedDateTime instead.
There is actually a unit test for this, but the MimeMessageBuilder adds a Date header by default if not specified. The test fix is to explicitly remove the Date header after building.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #730:
URL: https://github.com/apache/james-project/pull/730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #730:
URL: https://github.com/apache/james-project/pull/730#issuecomment-958642585
Nice contribution thanks!
Wondering why there is twice the exact same commit though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #730:
URL: https://github.com/apache/james-project/pull/730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #730:
URL: https://github.com/apache/james-project/pull/730#issuecomment-958656969
> Wondering why there is twice the exact same commit though?
My plan was to squash it all upon merge ;-)
> There is actually a unit test for this, but the MimeMessageBuilder adds a Date header by default if not specified. The test fix is to explicitly remove the Date header after building.
We might want to audit the code base, and MIME related tests regarding this defect. If it happened one time, we might have used a similar pattern in other places of the code and felt safe...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #730:
URL: https://github.com/apache/james-project/pull/730#issuecomment-958656969
> Wondering why there is twice the exact same commit though?
My plan was to squash it all upon merge ;-)
> There is actually a unit test for this, but the MimeMessageBuilder adds a Date header by default if not specified. The test fix is to explicitly remove the Date header after building.
We might want to audit the code base, and MIME related tests regarding this defect. If it happened one time, we might have used a similar pattern in other places of the code and felt safe...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #730:
URL: https://github.com/apache/james-project/pull/730#issuecomment-958642585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #730:
URL: https://github.com/apache/james-project/pull/730#issuecomment-958656969
> Wondering why there is twice the exact same commit though?
My plan was to squash it all upon merge ;-)
> There is actually a unit test for this, but the MimeMessageBuilder adds a Date header by default if not specified. The test fix is to explicitly remove the Date header after building.
We might want to audit the code base, and MIME related tests regarding this defect. If it happened one time, we might have used a similar pattern in other places of the code and felt safe...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #730:
URL: https://github.com/apache/james-project/pull/730#issuecomment-958642585
Nice contribution thanks!
Wondering why there is twice the exact same commit though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #730:
URL: https://github.com/apache/james-project/pull/730#issuecomment-958656969
> Wondering why there is twice the exact same commit though?
My plan was to squash it all upon merge ;-)
> There is actually a unit test for this, but the MimeMessageBuilder adds a Date header by default if not specified. The test fix is to explicitly remove the Date header after building.
We might want to audit the code base, and MIME related tests regarding this defect. If it happened one time, we might have used a similar pattern in other places of the code and felt safe...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #730: JAMES-3666 Fix DSNBounce exception when no Date header is present
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #730:
URL: https://github.com/apache/james-project/pull/730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org