You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/20 03:19:15 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request, #10185: Bump up Zipkin and Zipkin lens UI dependency to 2.24.0
wu-sheng opened a new pull request, #10185:
URL: https://github.com/apache/skywalking/pull/10185
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #10185: Bump up Zipkin and Zipkin lens UI dependency to 2.24.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #10185:
URL: https://github.com/apache/skywalking/pull/10185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10185: Bump up Zipkin and Zipkin lens UI dependency to 2.24.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358870805
@kezhenxu94 Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10185: Bump up Zipkin and Zipkin lens UI dependency to 2.24.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358789090
Do you mean I need to copy the lock file again from the Zipkin repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10185: Bump up Zipkin and Zipkin lens UI dependency to 2.24.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358788881
> No sure but you might need to regenerate the zipkin-license from the new Lens dependency's package.json and package-lock.jsonοΌ if they have new dependencies or versions changes in Lens, this is needed.
Could you provide which command I should run? I thought it is a part of CI check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #10185: Bump up Zipkin and Zipkin lens UI dependency to 2.24.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358788050
No sure but you might need to regenerate the zipkin-license from the new Lens dependency's package.json and package-lock.jsonοΌ if they have new dependencies or versions changes in Lens, this is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #10185: Bump up Zipkin and Zipkin lens UI dependency to 2.24.0
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #10185:
URL: https://github.com/apache/skywalking/pull/10185#issuecomment-1358817722
> Do you mean I need to copy the lock file again from the Zipkin repo?
You have to regenerate the zipkin-LICENSE from the package.json and package-lock.json in https://github.com/openzipkin/zipkin/tree/2.24.0/zipkin-lens, this is no part of CI because they are using npm 14 and we are using npm 16. Also, even we copy their package.json and package-lock.json, we have to manually copy those 2 files every time we upgrade the zipkin-lens version. So I'd just check in the generated ziplin-LICENSE file instead of check in the 2 large files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org