You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/01/28 18:59:16 UTC

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12288


Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC
......................................................................

IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Running against S3 and erasure coded HDFS causes slight changes in the
observed ExchangeScanRatio and breaks such downstream tests. This change
limits the affected test to HDFS local minicluster runs without EC.

Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb
---
M tests/query_test/test_observability.py
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/12288/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb
Gerrit-Change-Number: 12288
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 )

Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12288/4/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

http://gerrit.cloudera.org:8080/#/c/12288/4/tests/query_test/test_observability.py@396
PS4, Line 396:   @SkipIfNotHdfsMinicluster.tuned_for_minicluster
> Nit: This is triple conditional is hard to read. Skip if it is not an HDFS 
Just saw this comment, apologies for missing it during the initial round of reviews. I agree, these are somewhat hard to decipher, but I found over time they become more clear, and it's consistent with what we usually do. Maybe you can think of ways to make them more readable in general?



-- 
To view, visit http://gerrit.cloudera.org:8080/12288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb
Gerrit-Change-Number: 12288
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Feb 2019 06:53:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Hello Paul Rogers, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12288

to look at the new patch set (#2).

Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC
......................................................................

IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Running against S3 and erasure coded HDFS causes slight changes in the
observed ExchangeScanRatio and breaks such tests. This change limits
TestObservability::test_global_exchange_counters to HDFS local
minicluster runs without EC.

Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb
---
M tests/query_test/test_observability.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/12288/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb
Gerrit-Change-Number: 12288
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 )

Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Thanks for the reviews. Addressed Joe's comment, carrying his +2.

http://gerrit.cloudera.org:8080/#/c/12288/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12288/1//COMMIT_MSG@9
PS1, Line 9: Running against S3 and erasure coded HDFS causes slight changes in the
           : observed ExchangeScanRatio and breaks such tests. This change limits
           : TestObservability::test_global_exchange_counters to HDFS local
> Nit: Can you mention the test that you are skipping? Also, one can run this
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb
Gerrit-Change-Number: 12288
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 18:22:48 +0000
Gerrit-HasComments: Yes