[GitHub] stevedlawrence commented on a change in pull request #34: Daffodil 1884 bit order

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #34: Daffodil 1884 bit order
URL: https://github.com/apache/incubator-daffodil/pull/34#discussion_r166741490
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/unparsers/Unparser.scala
 ##########
 @@ -64,6 +64,10 @@ sealed trait Unparser
     if (ustate.dataProc.isDefined) ustate.dataProc.get.before(ustate, this)
     try {
       unparse(ustate)
+      this.context match {
+        case trd: TermRuntimeData => ustate.dataOutputStream.setPriorBitOrder(ustate.bitOrder)
+        case _ => //ok
+      }
 
 Review comment:
   As I recall, we had something similar ``this.context match {`` for the parse side of things, but I don't see it now. Maybe I'm misremembering or maybe it was replaced after a code review? Regardless, this doesn't exist on the parse side. Does parsing handle this differently or is this an inherent difference in parse vs. unparse so it is required here? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services