You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/09/16 09:49:34 UTC

[GitHub] [incubator-kyuubi] Yikf opened a new pull request, #3501: [KYUUBI #3497] Improve GitHub issue template

Yikf opened a new pull request, #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Fix https://github.com/apache/incubator-kyuubi/issues/3497
   
   This PR is intended to optimize improve GitHub issue template, aiming to add `Are you willing to submit PR?` 's options
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#discussion_r972979683


##########
.github/ISSUE_TEMPLATE/bug-report.yml:
##########
@@ -128,7 +128,9 @@ body:
         especially if you already know a good understanding of how to implement the fix.
         Kyuubi is a community-driven project and we love to bring new contributors in.
       options:
-        - label: Yes I am willing to submit a PR!
+        - label: Yes. I can contribute this feature independently.

Review Comment:
   it's better, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 closed pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3501: [KYUUBI #3497] Improve GitHub issue template
URL: https://github.com/apache/incubator-kyuubi/pull/3501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#discussion_r972969782


##########
.github/ISSUE_TEMPLATE/bug-report.yml:
##########
@@ -128,7 +128,9 @@ body:
         especially if you already know a good understanding of how to implement the fix.
         Kyuubi is a community-driven project and we love to bring new contributors in.
       options:
-        - label: Yes I am willing to submit a PR!
+        - label: Yes. I can contribute this feature independently.

Review Comment:
   How about like this?
   
   ```
   Yes. I can submit a PR independently to improve.
   Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
   No. I cannot submit a PR at this time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] Yikf commented on pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
Yikf commented on PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#issuecomment-1249164132

   Please take a look if you have a time ~ @pan3793 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#issuecomment-1249293746

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3501](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ae3e93) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/15fa49d39019155eb205890ddb708e19c95d78a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15fa49d) will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3501      +/-   ##
   ============================================
   + Coverage     51.65%   51.69%   +0.03%     
     Complexity       13       13              
   ============================================
     Files           482      482              
     Lines         26933    26933              
     Branches       3760     3760              
   ============================================
   + Hits          13913    13922       +9     
   + Misses        11663    11655       -8     
   + Partials       1357     1356       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `72.26% <0.00%> (-0.85%)` | :arrow_down: |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `80.74% <0.00%> (-0.63%)` | :arrow_down: |
   | [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `80.51% <0.00%> (ø)` | |
   | [...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvamRiYy9KREJDTWV0YWRhdGFTdG9yZS5zY2FsYQ==) | `89.96% <0.00%> (+0.69%)` | :arrow_up: |
   | [...ache/kyuubi/server/mysql/MySQLGenericPackets.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxHZW5lcmljUGFja2V0cy5zY2FsYQ==) | `78.72% <0.00%> (+2.12%)` | :arrow_up: |
   | [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `79.54% <0.00%> (+4.54%)` | :arrow_up: |
   | [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3501/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `20.00% <0.00%> (+6.15%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#discussion_r972984436


##########
.github/ISSUE_TEMPLATE/bug-report.yml:
##########
@@ -128,7 +128,9 @@ body:
         especially if you already know a good understanding of how to implement the fix.
         Kyuubi is a community-driven project and we love to bring new contributors in.
       options:
-        - label: Yes I am willing to submit a PR!
+        - label: Yes. I can contribute this feature independently.

Review Comment:
   flaky-test & bug report using "fix" and others using "improve"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#issuecomment-1249390392

   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#discussion_r972938469


##########
.github/ISSUE_TEMPLATE/bug-report.yml:
##########
@@ -128,7 +128,9 @@ body:
         especially if you already know a good understanding of how to implement the fix.
         Kyuubi is a community-driven project and we love to bring new contributors in.
       options:
-        - label: Yes I am willing to submit a PR!
+        - label: Yes. I can contribute this feature independently.

Review Comment:
   "feature" is not suitable here, could we improve the words?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#discussion_r972850751


##########
.github/ISSUE_TEMPLATE/flaky-test-report.yml:
##########
@@ -16,7 +16,7 @@
 #
 
 name: Flaky Test Report
-title: "[TEST]: "
+title: "[TEST]"

Review Comment:
   minor additional fixes, cc @yaooqinn 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3501: [KYUUBI #3497] Improve GitHub issue template

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3501:
URL: https://github.com/apache/incubator-kyuubi/pull/3501#discussion_r972976670


##########
.github/ISSUE_TEMPLATE/bug-report.yml:
##########
@@ -128,7 +128,9 @@ body:
         especially if you already know a good understanding of how to implement the fix.
         Kyuubi is a community-driven project and we love to bring new contributors in.
       options:
-        - label: Yes I am willing to submit a PR!
+        - label: Yes. I can contribute this feature independently.

Review Comment:
   How about using "fix" for bug, and "improve" for others?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org