You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphere.io> on 2013/10/31 21:09:39 UTC
Review Request 15144: Redirected navigation to framework page if slave was
gone.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15144/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Redirected navigation to framework page if slave was gone.
If an invalid slave ID is used in the redirect controller, redirect the
request to either the homepage or the frameworks page.
Fixes MESOS-650
Diffs
-----
src/webui/master/static/js/controllers.js 33dbc5de0b19b7b0f790929aea42018a1c757ed7
Diff: https://reviews.apache.org/r/15144/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 15144: Redirected navigation to framework page if slave
was gone.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Oct. 31, 2013, 8:18 p.m., Benjamin Hindman wrote:
> > Is there anyway to alert to the user that this slave is no longer valid and/or has failed? Maybe a TODO to do that in the future?
I will add a TODO for that. I do plan to add a service for adding flash-style messages at the top of the page, and this is the first candidate for it.
I will add that in another commit since this one is only intended to fix the exception being raised right now.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15144/#review27951
-----------------------------------------------------------
On Oct. 31, 2013, 8:11 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15144/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 8:11 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-650
> https://issues.apache.org/jira/browse/MESOS-650
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Redirected navigation to framework page if slave was gone.
>
> If an invalid slave ID is used in the redirect controller, redirect the
> request to either the homepage or the frameworks page.
>
> Fixes MESOS-650
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 33dbc5de0b19b7b0f790929aea42018a1c757ed7
>
> Diff: https://reviews.apache.org/r/15144/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 15144: Redirected navigation to framework page if slave
was gone.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15144/#review27951
-----------------------------------------------------------
Ship it!
Is there anyway to alert to the user that this slave is no longer valid and/or has failed? Maybe a TODO to do that in the future?
- Benjamin Hindman
On Oct. 31, 2013, 8:11 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15144/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 8:11 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-650
> https://issues.apache.org/jira/browse/MESOS-650
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Redirected navigation to framework page if slave was gone.
>
> If an invalid slave ID is used in the redirect controller, redirect the
> request to either the homepage or the frameworks page.
>
> Fixes MESOS-650
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 33dbc5de0b19b7b0f790929aea42018a1c757ed7
>
> Diff: https://reviews.apache.org/r/15144/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 15144: Redirected navigation to framework page if slave
was gone.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15144/#review27957
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Oct. 31, 2013, 8:11 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15144/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 8:11 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-650
> https://issues.apache.org/jira/browse/MESOS-650
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Redirected navigation to framework page if slave was gone.
>
> If an invalid slave ID is used in the redirect controller, redirect the
> request to either the homepage or the frameworks page.
>
> Fixes MESOS-650
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 33dbc5de0b19b7b0f790929aea42018a1c757ed7
>
> Diff: https://reviews.apache.org/r/15144/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 15144: Redirected navigation to framework page if slave
was gone.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15144/
-----------------------------------------------------------
(Updated Oct. 31, 2013, 8:11 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-650
https://issues.apache.org/jira/browse/MESOS-650
Repository: mesos-git
Description
-------
Redirected navigation to framework page if slave was gone.
If an invalid slave ID is used in the redirect controller, redirect the
request to either the homepage or the frameworks page.
Fixes MESOS-650
Diffs
-----
src/webui/master/static/js/controllers.js 33dbc5de0b19b7b0f790929aea42018a1c757ed7
Diff: https://reviews.apache.org/r/15144/diff/
Testing
-------
Thanks,
Ross Allen