You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/12 04:14:41 UTC
[GitHub] [skywalking] mrproliu opened a new pull request, #10269: Add documentation for profiling APIs
mrproliu opened a new pull request, #10269:
URL: https://github.com/apache/skywalking/pull/10269
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mrproliu commented on a diff in pull request #10269: Add documentation for profiling APIs
Posted by GitBox <gi...@apache.org>.
mrproliu commented on code in PR #10269:
URL: https://github.com/apache/skywalking/pull/10269#discussion_r1067755365
##########
docs/en/api/profiling-protocol.md:
##########
@@ -0,0 +1,277 @@
+# Profiling APIs
+
+SkyWalking offers two types of Profiling, Trace and eBPF, each with its own API.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10269: Add documentation for profiling APIs
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #10269:
URL: https://github.com/apache/skywalking/pull/10269#discussion_r1067752591
##########
docs/en/api/profiling-protocol.md:
##########
@@ -0,0 +1,277 @@
+# Profiling APIs
+
+SkyWalking offers two types of Profiling, Trace and eBPF, each with its own API.
Review Comment:
Please use concept page naming.
Such as in-process profiling.
https://skywalking.apache.org/docs/main/next/en/concepts-and-designs/profiling/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #10269: Add documentation for profiling APIs
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #10269:
URL: https://github.com/apache/skywalking/pull/10269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org