You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2011/10/17 03:11:20 UTC
DO NOT REPLY [Bug 118517] New: Update standard twain.h header to
version 2.1
https://issues.apache.org/ooo/show_bug.cgi?id=118517
Bug #: 118517
Issue Type: DEFECT
Summary: Update standard twain.h header to version 2.1
Classification: Test
Product: imported-component
Version: version58
Platform: PC
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: imported-subcomponent
AssignedTo: mh@openoffice.org
ReportedBy: pfg@apache.org
CC: ooo-issues@incubator.apache.org
Created attachment 76894
--> https://issues.apache.org/ooo/attachment.cgi?id=76894
Update twain from 1.9 to 2.1 (+mingw32)
OOo was using the twain header version 1.9. The new versions have nice
features:
Version 2.0 – Unix/Linux support, check scanning support, open source, 64-bit
Version 2.1 – Supported on Windows 7 (32 and 64 bit), support for automatic
color detection
I took the basic ideas from our local patches to add support for mingw32.
It is however untested so I will leave it here for a while for testers.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118517] Update standard twain.h header to version
2.1
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118517
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76894|0 |1
is obsolete| |
--- Comment #4 from Pedro Giffuni <pf...@apache.org> 2011-10-27 01:14:42 UTC ---
Created attachment 76934
--> https://issues.apache.org/ooo/attachment.cgi?id=76934
mingw32 isa now a special case of GNUC
Update: mingw32 is actually a special case of __GNUC__ and is valid also for 64
bits.
This patch preserves the original working order.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118517] Update standard twain.h header to version 2.1
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118517
Oliver-Rainer Wittmann (orw at apache dot org) <or...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--- Comment #6 from Oliver-Rainer Wittmann (orw at apache dot org) <or...@googlemail.com> ---
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118517] Update standard twain.h header to version
2.1
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118517
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ka@openoffice.org
--- Comment #3 from Pedro Giffuni <pf...@apache.org> 2011-10-19 13:48:01 UTC ---
*** Bug 106143 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118517] Update standard twain.h header to version
2.1
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118517
--- Comment #2 from Pedro Giffuni <pf...@apache.org> 2011-10-17 19:50:20 UTC ---
Hi;
Yes, I'd like to commit it but I need confirmation that it doesn't break the
build on Windows.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118517] Update standard twain.h header to version
2.1
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118517
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #5 from Pedro Giffuni <pf...@apache.org> 2011-10-28 21:55:38 UTC ---
I was wondering why not many projects have updated this and why
there doesn't seem to be mingw patches available.
Ming32 seems to be a bit weird as it sets __GNUC__ but according
to the Wine guys it looks like also defines itself as WIN32.
Maybe the original twain header works fine with Ming32 but JIC,
I made a workaround that should work with Mingw64 too: Mingw32
will be detected early and the 32 or 64 bit flags will be set
as if it were a Microsoft compiler but it will be forced to
behave as with our previous twain versions.
I haven't had feedback on the previous patches but this one
seems bulletproof.
twain/inc/twain.h
Committed as revision 1190602.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118517] Update standard twain.h header to version
2.1
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118517
oooforum <oo...@openoffice.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oooforum@openoffice.org
--- Comment #1 from oooforum <oo...@openoffice.org> 2011-10-17 09:10:57 UTC ---
Hi Pedro,
Do you think that this improvement will be integrated for 3.4 release?
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.