You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/27 03:56:27 UTC

[GitHub] [iotdb] weizihan0110 removed a comment on issue #2485: Introduce internalMNode type to avoid implementing MNode type directly

weizihan0110 removed a comment on issue #2485:
URL: https://github.com/apache/iotdb/issues/2485#issuecomment-768005274


   > Hi @weizihan0110 , thanks a lot for pointing out this issue.
   > 
   > Actually, we have `InternalMNode` at the beginning of the design (and that's why it appeared in the design document).
   > 
   > Afterwards, after `Allow SubDevices in IoTDB` function is supported (in PR #1323), we noticed that all types of `MNode` extend `InternalMNode`, which extends `MNode`. Therefore, we refactored `MNode` by removing `InternalMNode` and including all its methods.
   > 
   > Here is the related PR: #1345. You could see the `InternalMNode.java` is totally deleted.
   > 
   > However, we only considered "sub-devices" at that time, without considering creating parent node. So this decision may be reverted. What do you think? Would you like to try and implement the function that you need?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org