You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/12 20:18:00 UTC

[GitHub] [spark] MaxGekk opened a new pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

MaxGekk opened a new pull request #32134:
URL: https://github.com/apache/spark/pull/32134


   ### What changes were proposed in this pull request?
   1. Extend SQL syntax rules to support sign before ANSI interval strings of year-month and day-time intervals.
   2. Recognize `-` in AstBuilder and negate parsed intervals.
   
   ### Why are the changes needed?
   To conform the SQL standard which allows sign before the string intervals, see "5.3 <literal>":
   ```
   <interval literal> ::=
     INTERVAL [ <sign> ] <interval string> <interval qualifier>
   <interval string> ::=
     <quote> <unquoted interval string> <quote>
   <unquoted interval string> ::=
     [ <sign> ] { <year-month literal> | <day-time literal> }
   <sign> ::=
       <plus sign>
     | <minus sign>
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   Should not because it just extends supported intervals syntax.
   
   ### How was this patch tested?
   By running new tests in `interval.sql`:
   ```
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z interval.sql"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818365179


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137239/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818186715


   **[Test build #137239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137239/testReport)** for PR 32134 at commit [`9b44a38`](https://github.com/apache/spark/commit/9b44a38af03673387c8d0537ac0ab7ab6b159e44).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818355937


   **[Test build #137239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137239/testReport)** for PR 32134 at commit [`9b44a38`](https://github.com/apache/spark/commit/9b44a38af03673387c8d0537ac0ab7ab6b159e44).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818254022






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818256362


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41819/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818256362


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41819/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818458480


   The GA "Build and test / Scala 2.13 build with SBT (pull_request)" failed but I checked scala 2.13 locally:
   ```
   $ ./dev/change-scala-version.sh 2.13
   $ ./build/sbt -Pscala-2.13 compile
   [success] Total time: 145 s (02:25), completed Apr 13, 2021 8:50:50 AM
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818186715


   **[Test build #137239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137239/testReport)** for PR 32134 at commit [`9b44a38`](https://github.com/apache/spark/commit/9b44a38af03673387c8d0537ac0ab7ab6b159e44).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818365179


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137239/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32134:
URL: https://github.com/apache/spark/pull/32134#issuecomment-818459091


   Merging to master. Thank you @srowen for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #32134: [SPARK-35037][SQL] Recognize sign before the interval string in literals

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32134:
URL: https://github.com/apache/spark/pull/32134


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org