You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/05 09:34:41 UTC
[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

    [ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956576#comment-15956576 ] 

ASF GitHub Bot commented on FLINK-5256:
---------------------------------------

GitHub user DmytroShkvyra opened a pull request:

    https://github.com/apache/flink/pull/3673

    [FLINK-5256] Extend DataSetSingleRowJoin to support Left and Right joins

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ *] General
      - JIRA issue [FLINK-5256] Extend DataSetSingleRowJoin to support Left and Right joins
      - Continue of https://github.com/apache/flink/pull/3033 PR (by ex00)
    - [ ] Documentation
      - No
    - [* ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DmytroShkvyra/flink FLINK-5256

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3673
    
----
commit 2b941405338f3e6b41f3481bf2f40eefde6cb1a0
Author: DmytroShkvyra <ds...@gmail.com>
Date:   2017-04-05T09:24:30Z

    [FLINK-5256] Extend DataSetSingleRowJoin to support Left and Right joins

----


> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Dmytro Shkvyra
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and right joins with single input. These cases can be handled if the  {{DataSetSingleRowJoin}} is extended to support outer joins on the non-single-row input, i.e., left joins if the right side is single input and vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)