You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2018/05/17 21:54:48 UTC

Review Request 67197: HIVE-19588: Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67197/
-----------------------------------------------------------

Review request for hive and Eugene Koifman.


Bugs: HIVE-19588
    https://issues.apache.org/jira/browse/HIVE-19588


Repository: hive-git


Description
-------

HIVE-19588: Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a0ed2a0f48740825a4737d4bee63d8a90a 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a350e6bd44e52826b46707fb8727974e00bf 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java 5655ee9407d78ebc28a6e2b9c39ba55efc603a54 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java 8caa265e8b9bd5674a35083ccd81b873c9fc2c70 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java b28c126dbca8f1796dae5e8c5c5e256d18b1f86d 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 3acc0855fb07b51377ef665eea9abf9927c260c6 


Diff: https://reviews.apache.org/r/67197/diff/1/


Testing
-------


Thanks,

Prasanth_J


Re: Review Request 67197: HIVE-19588: Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67197/
-----------------------------------------------------------

(Updated May 18, 2018, 5:45 a.m.)


Review request for hive and Eugene Koifman.


Changes
-------

Removed VectorizedOrcAcidRowBatchReader creation from inner loop for LLAP.


Bugs: HIVE-19588
    https://issues.apache.org/jira/browse/HIVE-19588


Repository: hive-git


Description
-------

HIVE-19588: Several invocation of file listing when creating VectorizedOrcAcidRowBatchReader


Diffs (updated)
-----

  llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java 7451ea4 
  ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 183515a 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 2337a35 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java 5655ee9 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java 8caa265 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java b28c126 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 3acc085 


Diff: https://reviews.apache.org/r/67197/diff/2/

Changes: https://reviews.apache.org/r/67197/diff/1-2/


Testing
-------


Thanks,

Prasanth_J