[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1569: [#1568] rocketmq need enhance stability when commitlog broken

[GitBox <gi...@apache.org>]

duhenglucky commented on a change in pull request #1569: [#1568] rocketmq need enhance stability when commitlog broken
URL: https://github.com/apache/rocketmq/pull/1569#discussion_r342393162
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageBridge.java
 ##########
 @@ -176,7 +179,9 @@ private PullResult getMessage(String group, String topic, int queueId, long offs
             List<ByteBuffer> messageBufferList = getMessageResult.getMessageBufferList();
             for (ByteBuffer bb : messageBufferList) {
                 MessageExt msgExt = MessageDecoder.decode(bb);
-                foundList.add(msgExt);
+                if (msgExt != null) {
 
 Review comment:
   MessageExt msgExt = MessageDecoder.decode(bb); =》 MessageExt msgExt = MessageDecoder.decode(bb, true, false);
   to prevent the uncompress more that one times.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services