You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2013/04/02 16:31:19 UTC

[jira] [Commented] (BOOKKEEPER-577) BookieFailureTest uses sync/wait()/notify() incorrectly

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619851#comment-13619851 ] 

Ivan Kelly commented on BOOKKEEPER-577:
---------------------------------------

The assertion will should always hold. Otherwise the failureOccurred assertion will trigger. The while loop will exit in one way or another if the callback has been triggered. The movement of the assertion, while redundant is the correct way to check this. We shouldn't have assertions dependent on an action completing within a small time window in tests which have nothing to do with timeouts.
                
> BookieFailureTest uses sync/wait()/notify() incorrectly
> -------------------------------------------------------
>
>                 Key: BOOKKEEPER-577
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-577
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-577-BookieFailureTest-uses-sync-wait-noti.patch
>
>
> This makes it susceptible to spurious wakeup issues, which seem to hit very regularly on my laptop.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira