You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by "Christian Posta (JIRA)" <ji...@apache.org> on 2012/07/29 07:25:33 UTC

[jira] [Created] (APLO-230) Default timeout for OpenWire inactivity is incorrect

Christian Posta created APLO-230:
------------------------------------

             Summary: Default timeout for OpenWire inactivity is incorrect
                 Key: APLO-230
                 URL: https://issues.apache.org/jira/browse/APLO-230
             Project: ActiveMQ Apollo
          Issue Type: Bug
          Components: apollo-openwire
    Affects Versions: 1.3
            Reporter: Christian Posta


I think (based on what ActiveMQ has as its defaults) that the max_inactivity_duration and max_inactivity_duration_initial_delay default values might be incorrect. ActiveMQ has them at 30s:
From: OpenWireFormatFactory:
    private long maxInactivityDuration = 30*1000;
    private long maxInactivityDurationInitalDelay = 10*1000;

But Apollo has them set for 8.33 hrs:
DEFAULT_WIREFORMAT_SETTINGS.setMaxInactivityDuration(30 * 1000 * 1000);
  DEFAULT_WIREFORMAT_SETTINGS.setMaxInactivityDurationInitalDelay(10 * 1000 * 1000);

Patch is easy, can submit it, but just wanted to confirm that this is indeed wrong?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (APLO-230) Default timeout for OpenWire inactivity is incorrect

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/APLO-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved APLO-230.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4
         Assignee: Hiram Chirino
    
> Default timeout for OpenWire inactivity is incorrect
> ----------------------------------------------------
>
>                 Key: APLO-230
>                 URL: https://issues.apache.org/jira/browse/APLO-230
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-openwire
>    Affects Versions: 1.3
>            Reporter: Christian Posta
>            Assignee: Hiram Chirino
>             Fix For: 1.4
>
>
> I think (based on what ActiveMQ has as its defaults) that the max_inactivity_duration and max_inactivity_duration_initial_delay default values might be incorrect. ActiveMQ has them at 30s:
> From: OpenWireFormatFactory:
>     private long maxInactivityDuration = 30*1000;
>     private long maxInactivityDurationInitalDelay = 10*1000;
> But Apollo has them set for 8.33 hrs:
> DEFAULT_WIREFORMAT_SETTINGS.setMaxInactivityDuration(30 * 1000 * 1000);
>   DEFAULT_WIREFORMAT_SETTINGS.setMaxInactivityDurationInitalDelay(10 * 1000 * 1000);
> Patch is easy, can submit it, but just wanted to confirm that this is indeed wrong?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (APLO-230) Default timeout for OpenWire inactivity is incorrect

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/APLO-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424524#comment-13424524 ] 

Hiram Chirino commented on APLO-230:
------------------------------------

Thanks for spotting this.  You are correct.  This has now been fixed.
                
> Default timeout for OpenWire inactivity is incorrect
> ----------------------------------------------------
>
>                 Key: APLO-230
>                 URL: https://issues.apache.org/jira/browse/APLO-230
>             Project: ActiveMQ Apollo
>          Issue Type: Bug
>          Components: apollo-openwire
>    Affects Versions: 1.3
>            Reporter: Christian Posta
>             Fix For: 1.4
>
>
> I think (based on what ActiveMQ has as its defaults) that the max_inactivity_duration and max_inactivity_duration_initial_delay default values might be incorrect. ActiveMQ has them at 30s:
> From: OpenWireFormatFactory:
>     private long maxInactivityDuration = 30*1000;
>     private long maxInactivityDurationInitalDelay = 10*1000;
> But Apollo has them set for 8.33 hrs:
> DEFAULT_WIREFORMAT_SETTINGS.setMaxInactivityDuration(30 * 1000 * 1000);
>   DEFAULT_WIREFORMAT_SETTINGS.setMaxInactivityDurationInitalDelay(10 * 1000 * 1000);
> Patch is easy, can submit it, but just wanted to confirm that this is indeed wrong?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira