You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/26 09:25:57 UTC
[GitHub] [skywalking] viktoryi opened a new pull request #6084: correct the info in trace sampling doc with the latest configurations
viktoryi opened a new pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist π ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== π Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751339052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`8.3.0/docs-hotfix@81a0aa4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 8.3.0/docs-hotfix #6084 +/- ##
====================================================
Coverage ? 45.88%
Complexity ? 3119
====================================================
Files ? 902
Lines ? 22538
Branches ? 2177
====================================================
Hits ? 10341
Misses ? 11316
Partials ? 881
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=footer). Last update [81a0aa4...0efee62](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] viktoryi commented on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
viktoryi commented on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751340688
> You should send a pull request to the master, then I could cherry-pick this fix to the 8.3.0 doc. Could you reopen a new one?
Sure thing. [Here](https://github.com/apache/skywalking/pull/6085) it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751339052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`8.3.0/docs-hotfix@81a0aa4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 8.3.0/docs-hotfix #6084 +/- ##
====================================================
Coverage ? 39.77%
Complexity ? 2220
====================================================
Files ? 742
Lines ? 18689
Branches ? 1750
====================================================
Hits ? 7433
Misses ? 10686
Partials ? 570
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=footer). Last update [81a0aa4...0efee62](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751339052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`8.3.0/docs-hotfix@81a0aa4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 8.3.0/docs-hotfix #6084 +/- ##
====================================================
Coverage ? 43.48%
Complexity ? 2443
====================================================
Files ? 759
Lines ? 19189
Branches ? 1798
====================================================
Hits ? 8344
Misses ? 10208
Partials ? 637
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=footer). Last update [81a0aa4...0efee62](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751339052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751339052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751339052
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`8.3.0/docs-hotfix@81a0aa4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 8.3.0/docs-hotfix #6084 +/- ##
====================================================
Coverage ? 35.42%
Complexity ? 2017
====================================================
Files ? 742
Lines ? 18688
Branches ? 1748
====================================================
Hits ? 6620
Misses ? 11563
Partials ? 505
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=footer). Last update [81a0aa4...0efee62](https://codecov.io/gh/apache/skywalking/pull/6084?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6084: correct the info in trace sampling doc with the latest configurations
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6084:
URL: https://github.com/apache/skywalking/pull/6084#issuecomment-751338648
You should send a pull request to the master, then I could cherry-pick this fix to the 8.3.0 doc. Could you reopen a new one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org