You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by maoling <gi...@git.apache.org> on 2018/07/03 08:07:14 UTC
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
GitHub user maoling opened a pull request:
https://github.com/apache/zookeeper/pull/556
ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics
more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maoling/zookeeper ZOOKEEPER-3074
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #556
----
commit 9c0b04165f54d9d82292d20b98a8274ea5ed7357
Author: maoling <ma...@...>
Date: 2018-07-03T08:04:15Z
ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics
----
---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Posted by maoling <gi...@git.apache.org>.
Github user maoling closed the pull request at:
https://github.com/apache/zookeeper/pull/556
---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Posted by maoling <gi...@git.apache.org>.
GitHub user maoling reopened a pull request:
https://github.com/apache/zookeeper/pull/556
ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics
more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maoling/zookeeper ZOOKEEPER-3074
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #556
----
commit 9c0b04165f54d9d82292d20b98a8274ea5ed7357
Author: maoling <ma...@...>
Date: 2018-07-03T08:04:15Z
ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics
----
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/556
What was the issue? All tests passed but Jenkins still complains? The Jenkins check also includes findbug and forrrest (documentation) check if I remember correctly. Maybe it was find bug complaining?
In any case, I would reopen this PR which will kick off Jenkins and then we can start from there. There is no way of debugging without looking into the actual Jenkins job that complains.
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/556
yes, it did look like they passed, but it stayed as failed. kicking again.
---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Posted by maoling <gi...@git.apache.org>.
Github user maoling closed the pull request at:
https://github.com/apache/zookeeper/pull/556
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/556
As far as I remember Jenkins job finished successfully, but hasn't updated this PR's status.
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/556
>> As far as I remember Jenkins job finished successfully, but hasn't updated this PR's status.
It could be an infrastructure issue that Jenkins job failed to post the comment to github after it succeeded. If we still have to a link to that Jenkins job, i can take a look. Anyway, it's green now, and this one is ready to commit.
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/556
it would be nice to get this in. i'm on vacation right now. @anmolnar or @phunt do you have any idea how we can debug what is going on on jenkins?
---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/556
---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Posted by maoling <gi...@git.apache.org>.
GitHub user maoling reopened a pull request:
https://github.com/apache/zookeeper/pull/556
ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics
more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maoling/zookeeper ZOOKEEPER-3074
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #556
----
commit 9c0b04165f54d9d82292d20b98a8274ea5ed7357
Author: maoling <ma...@...>
Date: 2018-07-03T08:04:15Z
ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics
----
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/556
Merged to 3.5 and master branches.
Thanks @maoling !
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by maoling <gi...@git.apache.org>.
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/556
It seems that Jenkins doesn't like me, even doesn't reject me,let me wait and wait ,just like some girls I chase.
---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Posted by nkalmar <gi...@git.apache.org>.
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/556#discussion_r199726257
--- Diff: src/java/test/org/apache/zookeeper/server/ServerStatsTest.java ---
@@ -73,11 +73,11 @@ public void testLatencyMetrics() {
// Then ...
assertThat("Max latency check", 2000L,
- greaterThanOrEqualTo(serverStats.getMaxLatency()));
+ lessThanOrEqualTo(serverStats.getMaxLatency()));
--- End diff --
Thanks for catching this and fixing it! The serverstats.getMaxLatency() should of went in the "actual" parameter and the magic number as the greaterThanOrEqualTo parameter. (I did this test. Sorry...)
But changing greater to less work just fine.
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/556
+1 thank you @maoling !
i've restarted the build. if it passes, i'll get this committed.
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/556
Looks like it has already passed, status just hasn't been updated here.
---
[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/556
@maoling Would you please re-open the pull request and see how it goes?
I'll open an INFRA ticket, if it's hanging again.
---