You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by lq...@apache.org on 2016/11/18 11:10:04 UTC
svn commit: r1770362 -
/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java
Author: lquack
Date: Fri Nov 18 11:10:04 2016
New Revision: 1770362
URL: http://svn.apache.org/viewvc?rev=1770362&view=rev
Log:
QPID-7518: [Java Broker] make field variables volatile
Modified:
qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java
Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java?rev=1770362&r1=1770361&r2=1770362&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/transport/NonBlockingConnection.java Fri Nov 18 11:10:04 2016
@@ -52,7 +52,7 @@ public class NonBlockingConnection imple
private static final Logger LOGGER = LoggerFactory.getLogger(NonBlockingConnection.class);
private final SocketChannel _socketChannel;
- private NonBlockingConnectionDelegate _delegate;
+ private volatile NonBlockingConnectionDelegate _delegate;
private final Deque<NetworkConnectionScheduler> _schedulerDeque = new ConcurrentLinkedDeque<>();
private final ConcurrentLinkedQueue<QpidByteBuffer> _buffers = new ConcurrentLinkedQueue<>();
@@ -63,7 +63,7 @@ public class NonBlockingConnection imple
private volatile boolean _fullyWritten = true;
- private boolean _partialRead = false;
+ private volatile boolean _partialRead = false;
private final AmqpPort _port;
private final AtomicBoolean _scheduled = new AtomicBoolean();
@@ -71,12 +71,12 @@ public class NonBlockingConnection imple
private volatile boolean _unexpectedByteBufferSizeReported;
private final String _threadName;
private volatile SelectorThread.SelectionTask _selectionTask;
- private Iterator<Runnable> _pendingIterator;
+ private volatile Iterator<Runnable> _pendingIterator;
private final AtomicLong _maxWriteIdleMillis = new AtomicLong();
private final AtomicLong _maxReadIdleMillis = new AtomicLong();
private final List<SchedulingDelayNotificationListener> _schedulingDelayNotificationListeners = new CopyOnWriteArrayList<>();
private final AtomicBoolean _hasShutdown = new AtomicBoolean();
- private long _bufferedSize;
+ private volatile long _bufferedSize;
public NonBlockingConnection(SocketChannel socketChannel,
ProtocolEngine protocolEngine,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org