You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/31 19:21:08 UTC
[GitHub] [flink] HuangZhenQiu opened a new pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
HuangZhenQiu opened a new pull request #14823:
URL: https://github.com/apache/flink/pull/14823
## What is the purpose of the change
Fix the unstable ThresholdMeterTest with SystemClock
## Brief change log
- Move ThresholdMeter from flink-metrics to flink-runtime module
- Use Clock internally in ThresholdMeter
- Update ThresholdMeterTest with ManualClock to resolve the issue of clock jump in test cases.
## Verifying this change
This change added tests and can be verified as follows:
- It can be verified in the new ThresholdMeterTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770435644
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b5045c1695a3b0260a34d85077687b50a198a9cd (Fri May 28 08:15:41 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangZhenQiu commented on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
HuangZhenQiu commented on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770523596
@xintongsong
Thanks. Your changes are reasonable and needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* fe9b0d8824da2e50712f599978a4586bfe8f28a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
}, {
"hash" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720",
"triggerID" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"triggerType" : "PUSH"
}, {
"hash" : "b5045c1695a3b0260a34d85077687b50a198a9cd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12722",
"triggerID" : "b5045c1695a3b0260a34d85077687b50a198a9cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* b5045c1695a3b0260a34d85077687b50a198a9cd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12722)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #14823:
URL: https://github.com/apache/flink/pull/14823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-771287069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
xintongsong closed pull request #14823:
URL: https://github.com/apache/flink/pull/14823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
}, {
"hash" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720",
"triggerID" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* fe9b0d8824da2e50712f599978a4586bfe8f28a4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712)
* e97b4de046ec8231040f2c88b851a3fd69bf647b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* fe9b0d8824da2e50712f599978a4586bfe8f28a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
}, {
"hash" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* fe9b0d8824da2e50712f599978a4586bfe8f28a4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712)
* e97b4de046ec8231040f2c88b851a3fd69bf647b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
}, {
"hash" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720",
"triggerID" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"triggerType" : "PUSH"
}, {
"hash" : "b5045c1695a3b0260a34d85077687b50a198a9cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12722",
"triggerID" : "b5045c1695a3b0260a34d85077687b50a198a9cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* e97b4de046ec8231040f2c88b851a3fd69bf647b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720)
* b5045c1695a3b0260a34d85077687b50a198a9cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12722)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
}, {
"hash" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720",
"triggerID" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* e97b4de046ec8231040f2c88b851a3fd69bf647b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-771287844
Closed via b9e576fb845b817d804da3d68471ff8a4723dcf3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* fe9b0d8824da2e50712f599978a4586bfe8f28a4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770435644
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f0ba4a5828295c651491d7b031dd6c894375234b (Sun Jan 31 19:22:45 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-771287069
@zentol,
`ThresholdMeter` is introduced for tracing the rate of starting new worker failures, in FLINK-10868.
It's different from `MeterView` in the following ways:
* It needs to be updated on every event. (The events does not occur on a per-record bias.)
* It provides a `checkAgainstThreshold` method.
Thanks for the reminder on the commit tag. Merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
}, {
"hash" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12712",
"triggerID" : "fe9b0d8824da2e50712f599978a4586bfe8f28a4",
"triggerType" : "PUSH"
}, {
"hash" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720",
"triggerID" : "e97b4de046ec8231040f2c88b851a3fd69bf647b",
"triggerType" : "PUSH"
}, {
"hash" : "b5045c1695a3b0260a34d85077687b50a198a9cd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5045c1695a3b0260a34d85077687b50a198a9cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
* e97b4de046ec8231040f2c88b851a3fd69bf647b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12720)
* b5045c1695a3b0260a34d85077687b50a198a9cd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14823: [FLINK-21139][Build] Fix unstable ThresholdMeterTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14823:
URL: https://github.com/apache/flink/pull/14823#issuecomment-770437030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0ba4a5828295c651491d7b031dd6c894375234b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0ba4a5828295c651491d7b031dd6c894375234b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org