You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/14 08:09:00 UTC

[jira] [Work logged] (HDFS-16174) Implement temp file and dir in cc files

     [ https://issues.apache.org/jira/browse/HDFS-16174?focusedWorklogId=637933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637933 ]

ASF GitHub Bot logged work on HDFS-16174:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Aug/21 08:08
            Start Date: 14/Aug/21 08:08
    Worklog Time Spent: 10m 
      Work Description: GauthamBanasandra opened a new pull request #3303:
URL: https://github.com/apache/hadoop/pull/3303


   * Implemented TempFile and
     TempDir in cc files for avoiding
     duplicate compilation of these
     classes.
   * Wrapped these classes in a
     TestUtils namespace.
   * Created an object library for
     TestUtils and added this as a
     target as necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 637933)
    Remaining Estimate: 0h
            Time Spent: 10m

> Implement temp file and dir in cc files
> ---------------------------------------
>
>                 Key: HDFS-16174
>                 URL: https://issues.apache.org/jira/browse/HDFS-16174
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs++
>    Affects Versions: 3.4.0
>            Reporter: Gautham Banasandra
>            Assignee: Gautham Banasandra
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In C++, we generally do the declaration in the header files and the corresponding implementation in the .cc files. Here we see that the implementation of TempFile and TempDir are done in configuration_test.h itself. This offers no benefit and the compilation of TempFile and TempDir classes are duplicated for every #include of the configuration_test.h header. Thus, we need to implement it in separate cc files to avoid this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org