You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/19 16:00:39 UTC
[GitHub] [spark] cloud-fan opened a new pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
cloud-fan opened a new pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Improve the CREATE TABLE document:
1. mention that some clauses can come in as any order.
2. refine the description for some parameters.
3. mention how data source table interacts with data source
4. make the examples consistent between data source and hive serde tables.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
improve doc
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588305582
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588612231
thanks for review, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588604458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23446/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588606481
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27638: [SPARK-30878][SQL]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588296720
**[Test build #118679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118679/testReport)** for PR 27638 at commit [`d2bc474`](https://github.com/apache/spark/commit/d2bc4746eede0654eb9c3bae1e63b0ca97156964).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381718956
##########
File path: docs/sql-ref-syntax-ddl-create-table.md
##########
@@ -20,10 +20,10 @@ license: |
---
### Description
-`CREATE TABLE` statement is used to define a table in an exsisting database.
+`CREATE TABLE` statement is used to define a table in an existing database.
The CREATE statements:
-* [CREATE TABLE USING DATASOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
+* [CREATE TABLE USING DATA_SOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
Review comment:
English-wise, "data" and "source" are two words...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588296720
**[Test build #118679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118679/testReport)** for PR 27638 at commit [`d2bc474`](https://github.com/apache/spark/commit/d2bc4746eede0654eb9c3bae1e63b0ca97156964).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381828881
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -96,21 +97,37 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
### Examples
{% highlight sql %}
---Using Comment and loading data from another table into the created table
-CREATE TABLE StudentInfo
Review comment:
yea, ok. thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381667434
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -96,21 +97,37 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
### Examples
{% highlight sql %}
---Using Comment and loading data from another table into the created table
-CREATE TABLE StudentInfo
Review comment:
I think migration guide should be responsible for it ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588604454
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588305604
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118679/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638: [SPARK-30878][SQL]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588297485
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588604150
**[Test build #118695 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118695/testReport)** for PR 27638 at commit [`b340a54`](https://github.com/apache/spark/commit/b340a5480f38d3823e045eedc92f597be1cdd353).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381719333
##########
File path: docs/sql-ref-syntax-ddl-create-table.md
##########
@@ -20,10 +20,10 @@ license: |
---
### Description
-`CREATE TABLE` statement is used to define a table in an exsisting database.
+`CREATE TABLE` statement is used to define a table in an existing database.
The CREATE statements:
-* [CREATE TABLE USING DATASOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
+* [CREATE TABLE USING DATA_SOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
Review comment:
Let's go with `DATA_SOURCE` in public documents, we can fix the internal naming later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588604458
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23446/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638: [SPARK-30878][SQL]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588297513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23430/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588606486
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118695/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27638: [SPARK-30878][SQL][DOC]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588604150
**[Test build #118695 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118695/testReport)** for PR 27638 at commit [`b340a54`](https://github.com/apache/spark/commit/b340a5480f38d3823e045eedc92f597be1cdd353).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381612557
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -96,21 +97,37 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
### Examples
{% highlight sql %}
---Using Comment and loading data from another table into the created table
-CREATE TABLE StudentInfo
Review comment:
I think this is an important change for users, so how about describing the difference in 2.4/3.0 here, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381740742
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -96,21 +97,37 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
### Examples
{% highlight sql %}
---Using Comment and loading data from another table into the created table
-CREATE TABLE StudentInfo
Review comment:
yes we have. Search `CREATE TABLE` in https://github.com/apache/spark/blob/master/docs/sql-migration-guide.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588297513
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23430/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638: [SPARK-30878][SQL]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588305604
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118679/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588604454
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on issue #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588294473
cc @HyukjinKwon @viirya @maropu @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381615857
##########
File path: docs/sql-ref-syntax-ddl-create-table.md
##########
@@ -20,10 +20,10 @@ license: |
---
### Description
-`CREATE TABLE` statement is used to define a table in an exsisting database.
+`CREATE TABLE` statement is used to define a table in an existing database.
The CREATE statements:
-* [CREATE TABLE USING DATASOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
+* [CREATE TABLE USING DATA_SOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
Review comment:
nit: `DATA_SOURCE` is preferred against `DATASOURCE`? It seems the current codebase has both formats; https://gist.github.com/maropu/a7f780208ff50c990a52121378531c25
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381737898
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -96,21 +97,37 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
### Examples
{% highlight sql %}
---Using Comment and loading data from another table into the created table
-CREATE TABLE StudentInfo
Review comment:
I remember we already add a note for this in migration guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588606486
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118695/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381373033
##########
File path: docs/sql-ref-syntax-ddl-create-table-hiveformat.md
##########
@@ -96,21 +97,37 @@ CREATE [ EXTERNAL ] TABLE [ IF NOT EXISTS ] table_identifier
### Examples
{% highlight sql %}
---Using Comment and loading data from another table into the created table
-CREATE TABLE StudentInfo
Review comment:
the previous example was wrong. By default `CREATE TABLE` without USING created data source table in 3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27638: [SPARK-30878][SQL]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588294473
cc @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588606481
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381666358
##########
File path: docs/sql-ref-syntax-ddl-create-table.md
##########
@@ -20,10 +20,10 @@ license: |
---
### Description
-`CREATE TABLE` statement is used to define a table in an exsisting database.
+`CREATE TABLE` statement is used to define a table in an existing database.
The CREATE statements:
-* [CREATE TABLE USING DATASOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
+* [CREATE TABLE USING DATA_SOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
Review comment:
I am confused time to time if it's Datasource or Data source :-).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27638:
[SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#discussion_r381668205
##########
File path: docs/sql-ref-syntax-ddl-create-table.md
##########
@@ -20,10 +20,10 @@ license: |
---
### Description
-`CREATE TABLE` statement is used to define a table in an exsisting database.
+`CREATE TABLE` statement is used to define a table in an existing database.
The CREATE statements:
-* [CREATE TABLE USING DATASOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
+* [CREATE TABLE USING DATA_SOURCE](sql-ref-syntax-ddl-create-table-datasource.html)
Review comment:
Yea, if we can, better to use one of them consistently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27638:
[SPARK-30878][SQL] Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588297485
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27638: [SPARK-30878][SQL][DOC]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27638: [SPARK-30878][SQL][DOC] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588606405
**[Test build #118695 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118695/testReport)** for PR 27638 at commit [`b340a54`](https://github.com/apache/spark/commit/b340a5480f38d3823e045eedc92f597be1cdd353).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27638: [SPARK-30878][SQL]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588305582
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27638: [SPARK-30878][SQL]
Improve the CREATE TABLE document
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27638: [SPARK-30878][SQL] Improve the CREATE TABLE document
URL: https://github.com/apache/spark/pull/27638#issuecomment-588305322
**[Test build #118679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118679/testReport)** for PR 27638 at commit [`d2bc474`](https://github.com/apache/spark/commit/d2bc4746eede0654eb9c3bae1e63b0ca97156964).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org