You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/03/23 12:46:51 UTC
[GitHub] [incubator-livy] mgaido91 opened a new pull request #162:
[LIVY-572] Avoid usage of spark classes in ColumnBuffer
mgaido91 opened a new pull request #162: [LIVY-572] Avoid usage of spark classes in ColumnBuffer
URL: https://github.com/apache/incubator-livy/pull/162
## What changes were proposed in this pull request?
The `ColumnBuffers` can be created both inside spark jobs and in the Livy server. The latter case happens when operation logs are returned and fails before this patch because we are using Spark classes in this code after the refactor in LIVY-503. Unfortunately, we do not have test coverage for operation logs retrieval and this is the reason why this wasn't spot out earlier.
Since operation logs are retrieved by beeline for each query, this means that every query run through beeline fails, unless `livy.server.thrift.logging.operation.enabled` is set to `false`.
## How was this patch tested?
manual tests using beeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services