You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2023/09/20 06:59:42 UTC
[GitHub] [flink-benchmarks] Zakelly opened a new pull request, #79: [FLINK-33122][benchmark] Support null checkpoint data path for rescaling benchmarks
Zakelly opened a new pull request, #79:
URL: https://github.com/apache/flink-benchmarks/pull/79
Currently, when setting up a rescaling benchmark, a local checkpoint storage is created based on a local path configured by "benchmark.state.data-dir". When user does not provide value for this option, an exception is thrown. In this case, the right behavior should be to create a temporary directory for checkpoint, just like the `StateBackendBenchmarkUtils#createKeyedStateBackend` does for local data directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-benchmarks] masteryhx commented on a diff in pull request #79: [FLINK-33122][benchmark] Support null checkpoint data path for rescaling benchmarks
Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx commented on code in PR #79:
URL: https://github.com/apache/flink-benchmarks/pull/79#discussion_r1333857024
##########
src/main/java/org/apache/flink/state/benchmark/RescalingBenchmarkBase.java:
##########
@@ -57,6 +63,26 @@ public static void runBenchmark(Class<?> clazz) throws RunnerException {
new Runner(options).run();
}
+ protected static File prepareDirectory(String prefix) throws IOException {
Review Comment:
All code paths is similar with StateBenchmarkBase#createKeyedStateBackend and StateBackendBenchmarkUtils#prepareDirectory, Could we merge them together ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33122][benchmark] Support null checkpoint data path for rescaling benchmarks [flink-benchmarks]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on code in PR #79:
URL: https://github.com/apache/flink-benchmarks/pull/79#discussion_r1357891702
##########
src/main/java/org/apache/flink/state/benchmark/RescalingBenchmarkBase.java:
##########
@@ -57,6 +63,26 @@ public static void runBenchmark(Class<?> clazz) throws RunnerException {
new Runner(options).run();
}
+ protected static File prepareDirectory(String prefix) throws IOException {
Review Comment:
Hi @masteryhx , The `StateBackendBenchmarkUtils` belongs to the Flink repo and the `prepareDirectory` is a private method. I'd rather not change the Flink repo for the benchmark needs, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33122][benchmark] Support null checkpoint data path for rescaling benchmarks [flink-benchmarks]
Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx commented on code in PR #79:
URL: https://github.com/apache/flink-benchmarks/pull/79#discussion_r1366721747
##########
src/main/java/org/apache/flink/state/benchmark/RescalingBenchmarkBase.java:
##########
@@ -57,6 +63,26 @@ public static void runBenchmark(Class<?> clazz) throws RunnerException {
new Runner(options).run();
}
+ protected static File prepareDirectory(String prefix) throws IOException {
Review Comment:
Fine. I not insisted on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33122][benchmark] Support null checkpoint data path for rescaling benchmarks [flink-benchmarks]
Posted by "masteryhx (via GitHub)" <gi...@apache.org>.
masteryhx closed pull request #79: [FLINK-33122][benchmark] Support null checkpoint data path for rescaling benchmarks
URL: https://github.com/apache/flink-benchmarks/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org